LazyBuffer::get_at (+ simplify Combinations::nth)#917
Merged
Philippe-Cholet merged 1 commit intoApr 18, 2024
Conversation
Philippe-Cholet
requested changes
Apr 17, 2024
LazyBuffer::from_indices (+ simplify Combinations::nth)
96d2f7d to
3170c8d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #917 +/- ##
==========================================
+ Coverage 94.38% 94.45% +0.06%
==========================================
Files 48 48
Lines 6665 6866 +201
==========================================
+ Hits 6291 6485 +194
- Misses 374 381 +7 ☔ View full report in Codecov by Sentry. |
LazyBuffer::from_indices (+ simplify Combinations::nth)LazyBuffer::get_at (+ simplify Combinations::nth)
Philippe-Cholet
requested changes
Apr 17, 2024
Philippe-Cholet
left a comment
Member
There was a problem hiding this comment.
Away from the keyboard, I thought that from_ methods usually are constructors (returns Self) which is not the case here. So get_at is a better name than my suggested from_indices.
I'll merge this once the requested change is done, thanks.
3170c8d to
68df645
Compare
Philippe-Cholet
approved these changes
Apr 18, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #914 (comment), I've added a helper for returning the 'current' combination.
I also realised that there's no reason to delegate from
.nthto.next()whenn==0so I junked it.