Skip to content

[RFC] initial Cortex-R team#199

Merged
bors[bot] merged 1 commit into
masterfrom
cortex-r
Sep 6, 2018
Merged

[RFC] initial Cortex-R team#199
bors[bot] merged 1 commit into
masterfrom
cortex-r

Conversation

@japaric

@japaric japaric commented Sep 1, 2018

Copy link
Copy Markdown
Member

This is a proposal for creating a Cortex-R team.

@paoloteti and I will be the initial members. I know pretty much nothing about
the Cortex-R but will be working with them starting November; @paoloteti is the
real expert here.

The following work has been planed for this team (some of it has been done
already)

  • Add more built-in targets to cover existing devices. In
    add more Cortex-R targets rust-lang/rust#53679 we went from 1 target to 4. We now have good coverage of
    Cortex R4(F) and R5(F) cores.

  • Move to LLD to remove the dependency on a external linker. Done in
    add more Cortex-R targets rust-lang/rust#53679.

  • Produce rust-std components to not depend on tools like Xargo, which
    require nightly. Also done in add more Cortex-R targets rust-lang/rust#53679.

  • Create a cortex-r crate (*) akin to the cortex-m crate that provides
    a safe API to emit arch-specific instructions and to manipulate system
    registers.

  • Create a cortex-r-rt crate (*) akin to the cortex-m-rt crate that
    helps building a minimal no_std binary.

  • See if we can generate register APIs from the XML files that vendors like
    TI ship with their IDEs.

(*) Initial work in this area: https://github.com/paoloteti/ti-hercules-bsp

@rust-embedded/all please vote on this proposal using GitHub reviews.
This proposal needs at least 11 approvals to land (/all has 21 members atm).

@japaric japaric added the needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged label Sep 1, 2018
@japaric japaric requested review from a team, dylanmckay and jcsoo as code owners September 1, 2018 20:30

@therealprof therealprof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

@japaric japaric mentioned this pull request Sep 1, 2018

@korken89 korken89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm looking forward to see what happens here!

@jamesmunns jamesmunns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Welcome @paoloteti!

@japaric

japaric commented Sep 6, 2018

Copy link
Copy Markdown
Member Author

🔔 This has been approved.

bors r+

Welcome to the WG, @paoloteti!

@bors

bors Bot commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

👎 Rejected by label

@japaric japaric added decision-accepted We voted on this proposal and accepted it and removed needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged labels Sep 6, 2018
@japaric

japaric commented Sep 6, 2018

Copy link
Copy Markdown
Member Author

sudo
bors r+

bors Bot added a commit that referenced this pull request Sep 6, 2018
199: [RFC] initial Cortex-R team r=japaric a=japaric

This is a proposal for creating a Cortex-R team.

@paoloteti and I will be the initial members. I know pretty much nothing about
the Cortex-R but will be working with them starting November; @paoloteti is the
real expert here.

The following work has been planed for this team (some of it has been done
already)

- [x] Add more built-in targets to cover existing devices. In
  rust-lang/rust#53679 we went from 1 target to 4. We now have good coverage of
  Cortex R4(F) and R5(F) cores.

- [x] Move to LLD to remove the dependency on a external linker. Done in
  rust-lang/rust#53679.

- [x] Produce `rust-std` components to not depend on tools like Xargo, which
  require nightly. Also done in rust-lang/rust#53679.

- [ ] Create a `cortex-r` crate (\*) akin to the `cortex-m` crate that provides
  a safe API to emit arch-specific instructions and to manipulate system
  registers.

- [ ] Create a `cortex-r-rt` crate (\*) akin to the `cortex-m-rt` crate that
  helps building a minimal `no_std` binary.

- [ ] See if we can generate register APIs from the XML files that vendors like
  TI ship with their IDEs.

(\*) Initial work in this area: https://github.com/paoloteti/ti-hercules-bsp

@rust-embedded/all please vote on this proposal using [GitHub reviews][approve].
This proposal needs at least 11 approvals to land (/all has 21 members atm).

[approve]: https://help.github.com/articles/approving-a-pull-request-with-required-reviews/


Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors

bors Bot commented Sep 6, 2018

Copy link
Copy Markdown
Contributor

Build succeeded

@bors bors Bot merged commit 0a516ea into master Sep 6, 2018
@bors bors Bot deleted the cortex-r branch September 6, 2018 15:48
@japaric japaric mentioned this pull request Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

decision-accepted We voted on this proposal and accepted it

Projects

None yet

Development

Successfully merging this pull request may close these issues.