Test fixes

Author: rubiojr

pkg/config/config_test.go

@@ -7,9 +7,8 @@ import (
 
 	"github.com/BurntSushi/toml"
 	"github.com/stretchr/testify/assert"
-	"github.com/urfave/cli/v2"
 
-	"github.com/rubiojr/hashup/internal/config"
+	"github.com/rubiojr/hashup/pkg/config"
 )
 
 func TestDefaultConfig(t *testing.T) {
@@ -97,104 +96,6 @@ func TestSaveConfig(t *testing.T) {
 	assert.Equal(t, "nats://customserver:4222", loadedCfg.Main.NatsServerURL)
 }
 
-func TestLoadConfigFromCLI(t *testing.T) {
-	t.Skip("broken")
-	tempDir := t.TempDir()
-	configPath := filepath.Join(tempDir, "cli_config.toml")
-
-	// Create a basic config file
-	basicCfg := config.DefaultConfig()
-	err := config.SaveConfig(basicCfg, configPath)
-	assert.NoError(t, err)
-
-	tests := []struct {
-		name     string
-		args     []string
-		validate func(*testing.T, *config.Config)
-	}{
-		{
-			name: "Custom config file",
-			args: []string{"--config", configPath},
-			validate: func(t *testing.T, cfg *config.Config) {
-				assert.Equal(t, configPath, cfg.Path)
-			},
-		},
-		{
-			name: "Custom encryption key",
-			args: []string{"--config", configPath, "--encryption-key", "testkey123"},
-			validate: func(t *testing.T, cfg *config.Config) {
-				assert.Equal(t, "testkey123", cfg.Main.EncryptionKey)
-			},
-		},
-		{
-			name: "Custom DB path",
-			args: []string{"--config", configPath, "--db-path", "/custom/db/path"},
-			validate: func(t *testing.T, cfg *config.Config) {
-				assert.Equal(t, "/custom/db/path", cfg.Store.DBPath)
-			},
-		},
-		{
-			name: "Custom stats interval",
-			args: []string{"--config", configPath, "--stats-interval", "120"},
-			validate: func(t *testing.T, cfg *config.Config) {
-				assert.Equal(t, 120, cfg.Store.StatsInterval)
-			},
-		},
-		{
-			name: "Custom NATS URL",
-			args: []string{"--config", configPath, "--nats-url", "nats://custom:4222"},
-			validate: func(t *testing.T, cfg *config.Config) {
-				assert.Equal(t, "nats://custom:4222", cfg.Main.NatsServerURL)
-			},
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			app := cli.NewApp()
-			ctx := cli.NewContext(app, nil, nil)
-
-			// Set up flags
-			flags := map[string]any{
-				"config":         configPath,
-				"encryption-key": "",
-				"db-path":        "",
-				"stats-interval": 0,
-				"nats-url":       "",
-				"stream":         "",
-				"client-cert":    "",
-				"client-key":     "",
-				"ca-cert":        "",
-			}
-
-			// Apply command line args
-			for i := 0; i < len(tt.args); i += 2 {
-				if i+1 < len(tt.args) {
-					flagName := tt.args[i][2:] // Remove --
-					flagValue := tt.args[i+1]
-					flags[flagName] = flagValue
-				}
-			}
-
-			// Set values in the context
-			for name, value := range flags {
-				switch v := value.(type) {
-				case string:
-					ctx.Set(name, v)
-				case int:
-					if v != 0 {
-						ctx.Set(name, string(rune(v)))
-					}
-				}
-			}
-
-			cfg, err := config.LoadConfigFromCLI(ctx)
-			assert.NoError(t, err)
-			tt.validate(t, cfg)
-		})
-	}
-}
-
 func TestDefaultPaths(t *testing.T) {
 	homeDir, _ := os.UserHomeDir()