Skip to content

Fix: JRuby PLS_INTEGER, BINARY_INTEGER NULL value becomes 0 #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javornikolov merged 1 commit into from
Jun 3, 2015
Merged

Fix: JRuby PLS_INTEGER, BINARY_INTEGER NULL value becomes 0 #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/plsql/jdbc_connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def set_bind_variable(stmt, i, value, type=nil, length=nil, metadata={})
def get_bind_variable(stmt, i, type)
case type.to_s.to_sym
when :Fixnum, :Bignum, :Integer
stmt.getInt(i)
stmt.getObject(i)
when :Float
stmt.getFloat(i)
when :BigDecimal
Expand Down
99 changes: 99 additions & 0 deletions spec/plsql/procedure_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2102,3 +2102,102 @@ def new_candidate(status)
end

end

describe "PLS_INTEGER/SIMPLE_INTEGER should be nullable" do

before(:all) do
plsql.connect! CONNECTION_PARAMS
plsql.execute <<-SQL
CREATE OR REPLACE FUNCTION test_pls_f ( p_num PLS_INTEGER ) RETURN PLS_INTEGER IS
BEGIN
RETURN p_num;
END;
SQL
plsql.execute <<-SQL
CREATE OR REPLACE FUNCTION test_bin_f ( p_num BINARY_INTEGER ) RETURN BINARY_INTEGER IS
BEGIN
RETURN p_num;
END;
SQL
plsql.execute <<-SQL
CREATE OR REPLACE FUNCTION test_int_f ( p_num INTEGER ) RETURN INTEGER IS
BEGIN
RETURN p_num;
END;
SQL
plsql.execute <<-SQL
CREATE OR REPLACE PROCEDURE test_pls_p ( p_num IN OUT PLS_INTEGER ) IS
BEGIN
NULL;
END;
SQL
plsql.execute <<-SQL
CREATE OR REPLACE PROCEDURE test_bin_p ( p_num IN OUT BINARY_INTEGER ) IS
BEGIN
NULL;
END;
SQL
plsql.execute <<-SQL
CREATE OR REPLACE PROCEDURE test_int_p ( p_num IN OUT INTEGER ) IS
BEGIN
NULL;
END;
SQL
plsql.execute <<-SQL
CREATE OR REPLACE PROCEDURE test_flt_p ( p_num IN OUT BINARY_FLOAT ) IS
BEGIN
NULL;
END;
SQL
plsql.execute <<-SQL
CREATE OR REPLACE PROCEDURE test_dbl_p ( p_num IN OUT BINARY_DOUBLE ) IS
BEGIN
NULL;
END;
SQL
end

after(:all) do
plsql.execute "DROP FUNCTION test_pls_f"
plsql.execute "DROP FUNCTION test_bin_f"
plsql.execute "DROP FUNCTION test_int_f"
plsql.execute "DROP PROCEDURE test_pls_p"
plsql.execute "DROP PROCEDURE test_int_p"
plsql.execute "DROP PROCEDURE test_flt_p"
plsql.execute "DROP PROCEDURE test_dbl_p"
plsql.logoff
end

it 'should return null for a function call with NULL PLS_INTEGER param' do
expect(plsql.test_pls_f(nil)).to be_nil
end

it 'should return null for a function call with NULL BINARY_INTEGER param' do
expect(plsql.test_bin_f(nil)).to be_nil
end

it 'should return null for a function call with NULL INTEGER param' do
expect(plsql.test_int_f(nil)).to be_nil
end

it 'should return null for a procedure call with NULL PLS_INTEGER param' do
expect(plsql.test_pls_p(nil)[:p_num]).to be_nil
end

it 'should return null for a procedure call with NULL BINARY_INTEGER param' do
expect(plsql.test_bin_p(nil)[:p_num]).to be_nil
end

it 'should return null for a procedure call with NULL INTEGER param' do
expect(plsql.test_int_p(nil)[:p_num]).to be_nil
end

it 'should return null for a procedure call with NULL BINARY_FLOAT param' do
expect(plsql.test_flt_p(nil)[:p_num]).to be_nil
end

it 'should return null for a procedure call with NULL BINARY_DOUBLE param' do
expect(plsql.test_dbl_p(nil)[:p_num]).to be_nil
end

end