-
Notifications
You must be signed in to change notification settings - Fork 133
FE-348: Update Next to 12.2 and use SWC instead of Babel #7291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ref: see the Next source logic for deciding what browsers to use: https://github.com/vercel/next.js/blob/1feaac03986e9cfa3cd073e76981261854e196ce/packages/next/build/webpack-config.ts#L65-L92
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const message = getQueryValue(req.query.error_description!); | ||
|
|
||
| res.redirect("/browser/error?type=auth&message=" + encodeURIComponent(message)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untrusted user input in redirect() can result in Open Redirect vulnerability. (Lines 87-89)
🙈 From ajinabraham.njsscan.open_redirect.express_open_redirect.
✅ QA Wolf - Deploy PR
✅ 8 passed |
b554dcc to
a6a2be3
Compare
bvaughn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
|
While not actually changes in the PR itself, I'm trying out some alternate settings with Vercel to see if I can get it to do a better job of caching Yarn's |
|
Also: this PR does not update Jest to use SWC, or remove any of our Babel deps. We oughta try that later. |
3fd23c6 to
a6a2be3
Compare
|
Success! |








This PR:
browserslistsetting to continue targeting"chrome 95"instead of the default list of browsersPer local build checks, I've confirmed that SWC + the default browsers adds about 40KB per bundle on top of Babel (where we have about 550KB as a baseline), but SWC +
"chrome 95"drops 8KB. So, a very small win for bundle size.Compile times in dev seem to drop from 40s for
/and 26s for/recording, to 20s and 13s respectively.