Skip to content

Commit 5128369

Browse files
authored
🔥 ( Hot-Fix )(resolved-conflict): Rectification of code by removing all (jsx-A11y) warnings (Conflict Resolved) (#47)
* Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings * hot-fix: Drawer component now closes on clicking playground icon
1 parent 084cf38 commit 5128369

4 files changed

Lines changed: 12 additions & 8 deletions

File tree

‎src/components/Footer/index.jsx‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,24 +17,25 @@ function Footer() {
1717
<Grid container spacing={5} justify="center">
1818
<Grid item xs={12} md={6} lg={4}>
1919
<Typography variant="h4" style={{ marginBottom: 10 }}>
20-
Playground 🚀
20+
Playground <span role="img" aria-label="playground">🚀</span>
2121
</Typography>
2222

2323
<Divider />
2424

2525
<a
2626
href="https://github.com/react-native-elements/playground"
2727
target="_blank"
28+
rel="noopener noreferrer"
2829
>
2930
<Typography>GitHub Repositoy</Typography>
3031
</a>
3132

32-
<a href="https://reactnativeelements.com/" target="_blank">
33+
<a href="https://reactnativeelements.com/" target="_blank" rel="noopener noreferrer">
3334
<Typography>Official Docs</Typography>
3435
</a>
3536
<br />
3637

37-
<a href="https://www.netlify.com">
38+
<a href="https://www.netlify.com" target="_blank" rel="noopener noreferrer">
3839
<img
3940
src="https://www.netlify.com/img/global/badges/netlify-color-accent.svg"
4041
alt="Deploys by Netlify"
@@ -46,6 +47,7 @@ function Footer() {
4647
<a
4748
href="https://github.com/react-native-elements/react-native-elements/"
4849
target="_blank"
50+
rel="noopener noreferrer"
4951
>
5052
<Typography variant="h6">React Native Elements</Typography>
5153
<Typography
@@ -58,6 +60,7 @@ function Footer() {
5860
<img
5961
src={require("../../assets/RNE_Logo.png")}
6062
className={styles.footer_product_img}
63+
alt="react-native-elements-logo"
6164
/>
6265

6366
<img

‎src/containers/Drawer/index.jsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ function ResponsiveDrawer(props) {
9191
const drawer = (
9292
<div>
9393
<div style={{ padding: "0.5rem" }}>
94-
<Link to="/">
95-
<Typography variant="h5">Playground 🚀</Typography>
94+
<Link to="/" onClick={() => handleDrawerToggle(false)}>
95+
<Typography variant="h5">Playground <span role="img" aria-label="playground" >🚀</span></Typography>
9696
</Link>
9797
</div>
9898
<List>
@@ -140,7 +140,7 @@ function ResponsiveDrawer(props) {
140140
</Typography>
141141
</Link>
142142
<div style={{ marginLeft: "auto" }}>
143-
<a href="https://reactnativeelements.com/" target="_blank">
143+
<a href="https://reactnativeelements.com/" target="_blank" rel="noopener noreferrer">
144144
<Button color="inherit">Docs</Button>
145145
</a>
146146
<IconButton

‎src/containers/Navigation/index.jsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ export default function App() {
186186
})}
187187
<Route exact path="/explore">
188188
<Helmet>
189-
<title>Explore | Playground 🚀 - React Native Elements</title>
189+
<title>Explore | Playground <span role="img" aria-label="playground">🚀</span> - React Native Elements</title>
190190
</Helmet>
191191
<ExplorePage />
192192
</Route>

‎src/pages/home/index.jsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function HomePage() {
3333
<div style={{ width: "100%", textAlign: "center", marginBottom: "2rem" }}>
3434
<Link to="/explore">
3535
<Button variant="outlined" color="secondary">
36-
<Typography variant="h6">Explore Now 🌇</Typography>
36+
<Typography variant="h6">Explore Now <span role="img" aria-label="explore">🌇</span></Typography>
3737
</Button>
3838
</Link>
3939
</div>
@@ -93,6 +93,7 @@ const FeatureCard = (props) => {
9393
margin: "auto",
9494
display: "flex",
9595
}}
96+
alt="playground-banner"
9697
src={props.banner}
9798
/>
9899
<div style={{ bottom: 0, marginTop: "1rem" }}>

0 commit comments

Comments
 (0)