Skip to content

chore(web-console): make autocomplete case-insensitive#366

Merged
nwoolmer merged 7 commits into
mainfrom
web-console/case-insensitive-autocomplete
Jan 20, 2025
Merged

chore(web-console): make autocomplete case-insensitive#366
nwoolmer merged 7 commits into
mainfrom
web-console/case-insensitive-autocomplete

Conversation

@insmac

@insmac insmac commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Fixes an issue in which lower and upper case tokens trigger different suggestion set. In the example below, FROM should display exactly the same list as from:

Screenshot 2025-01-02 at 12 07 11 Screenshot 2025-01-02 at 12 07 06

Additionally, column suggestions should not be displayed when not applicable, i.e.

display suggestion set:

SELECT column1, <cursor>

do not display suggestion set:

SELECT column1 <cursor>

@nwoolmer

nwoolmer commented Jan 20, 2025

Copy link
Copy Markdown
Contributor

Hey @insmac !

Prioritisation is still a little odd:

image

My expectation would be that the keyword would take precedence over the table, especially since it is shorter.

Maybe the current behaviour makes sense and we can't alter this until we have AST-aware syntax highlighting?

Also, the suggestions list doesn't update after dropping a table. Should we refresh this when we make DDL changes that will affect the suggestions list? Or just rely on hard browser refresh?

PEBCAK!

nwoolmer
nwoolmer previously approved these changes Jan 20, 2025
@nwoolmer nwoolmer merged commit 1108d81 into main Jan 20, 2025
@nwoolmer nwoolmer deleted the web-console/case-insensitive-autocomplete branch January 20, 2025 14:02
Vaibhav91one pushed a commit to Vaibhav91one/ui that referenced this pull request Oct 28, 2025
* Match case-insensitive in language completions

* Improve column completion triggers

* submodule update

* Add tests

* submodule update

* submodule update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants