fix(dispatch): Add default source resolver to Attributes

Attributes has a field for the default source for the method. This lets us remove the WithSource calls throughout the cmd package, and makes tests more readable.

Author: dustmop

cmd/pull.go

@@ -37,7 +37,7 @@ dataset version(s). By default pull fetches the latest version of a dataset.
 	}
 
 	cmd.Flags().StringVar(&o.LinkDir, "link", "", "path to directory to link dataset to")
-	cmd.Flags().StringVar(&o.Source, "source", "network", "location to pull from")
+	cmd.Flags().StringVar(&o.Source, "source", "", "location to pull from")
 	cmd.MarkFlagFilename("link")
 	cmd.Flags().BoolVar(&o.LogsOnly, "logs-only", false, "only fetch logs, skipping HEAD data")
 

cmd/remove.go

@@ -152,7 +152,7 @@ func (o *RemoveOptions) Run() (err error) {
 	}
 
 	ctx := context.TODO()
-	res, err := o.inst.WithSource("local").Dataset().Remove(ctx, &params)
+	res, err := o.inst.Dataset().Remove(ctx, &params)
 	if err != nil {
 		// TODO(b5): move this error handling down into lib
 		if errors.Is(err, dsref.ErrRefNotFound) {

cmd/validate.go

@@ -138,7 +138,7 @@ func (o *ValidateOptions) Run() (err error) {
 	}
 
 	ctx := context.TODO()
-	res, err := o.inst.WithSource("local").Dataset().Validate(ctx, p)
+	res, err := o.inst.Dataset().Validate(ctx, p)
 	if err != nil {
 		return err
 	}

lib/access.go

@@ -22,7 +22,7 @@ func (m AccessMethods) Name() string {
 // Attributes defines attributes for each method
 func (m AccessMethods) Attributes() map[string]AttributeSet {
 	return map[string]AttributeSet{
-		"createauthtoken": {AECreateAuthToken, "GET"},
+		"createauthtoken": {AECreateAuthToken, "GET", "local"},
 	}
 }
 

lib/automation.go

@@ -26,7 +26,7 @@ func (m AutomationMethods) Name() string {
 // Attributes defines attributes for each method
 func (m AutomationMethods) Attributes() map[string]AttributeSet {
 	return map[string]AttributeSet{
-		"apply": {AEApply, "POST"},
+		"apply": {AEApply, "POST", ""},
 	}
 }
 

lib/collection.go

@@ -27,8 +27,8 @@ func (m CollectionMethods) Name() string {
 // Attributes defines attributes for each method
 func (m CollectionMethods) Attributes() map[string]AttributeSet {
 	return map[string]AttributeSet{
-		"list":        {AEList, "POST"},
-		"listrawrefs": {denyRPC, ""},
+		"list":        {AEList, "POST", ""},
+		"listrawrefs": {denyRPC, "", ""},
 	}
 }
 

lib/config.go

@@ -25,9 +25,9 @@ func (m ConfigMethods) Name() string {
 func (m ConfigMethods) Attributes() map[string]AttributeSet {
 	return map[string]AttributeSet{
 		// config methods are not allowed over HTTP nor RPC
-		"getconfig":     {denyRPC, ""},
-		"getconfigkeys": {denyRPC, ""},
-		"setconfig":     {denyRPC, ""},
+		"getconfig":     {denyRPC, "", ""},
+		"getconfigkeys": {denyRPC, "", ""},
+		"setconfig":     {denyRPC, "", ""},
 	}
 }
 

lib/datasets.go

@@ -50,20 +50,20 @@ func (m DatasetMethods) Name() string {
 // Attributes defines attributes for each method
 func (m DatasetMethods) Attributes() map[string]AttributeSet {
 	return map[string]AttributeSet{
-		"componentstatus": {AEComponentStatus, "POST"},
-		"get":             {AEGet, "GET"},
+		"componentstatus": {AEComponentStatus, "POST", ""},
+		"get":             {AEGet, "GET", ""},
 		// "log":             {AELog, "POST"},
-		"rename": {AERename, "POST"},
-		"save":   {AESave, "POST"},
-		"pull":   {AEPull, "POST"},
+		"rename": {AERename, "POST", ""},
+		"save":   {AESave, "POST", ""},
+		"pull":   {AEPull, "POST", "network"},
 		// "push":            {AEPush, "POST"},
-		"render":   {AERender, "POST"},
-		"remove":   {AERemove, "POST"},
-		"validate": {AEValidate, "POST"},
+		"render":   {AERender, "POST", ""},
+		"remove":   {AERemove, "POST", "local"},
+		"validate": {AEValidate, "POST", ""},
 		// "unpack":          {AEUnpack, "POST"},
-		"manifest":        {AEManifest, "POST"},
-		"manifestmissing": {AEManifestMissing, "POST"},
-		"daginfo":         {AEDAGInfo, "POST"},
+		"manifest":        {AEManifest, "POST", ""},
+		"manifestmissing": {AEManifestMissing, "POST", ""},
+		"daginfo":         {AEDAGInfo, "POST", ""},
 	}
 }
 
@@ -1311,9 +1311,6 @@ func (datasetImpl) Validate(scope scope, p *ValidateParams) (*ValidateResponse,
 	if p.Ref == "" && (p.BodyFilename == "" || schemaFlagType == "") {
 		return nil, qrierr.New(ErrBadArgs, "please provide a dataset name, or a supply the --body and --schema or --structure flags")
 	}
-	if scope.SourceName() != "local" {
-		return nil, fmt.Errorf("validate requires 'local' source")
-	}
 
 	fsiPath := ""
 	var err error

lib/diff.go

@@ -26,8 +26,8 @@ func (m DiffMethods) Name() string {
 // Attributes defines attributes for each method
 func (m DiffMethods) Attributes() map[string]AttributeSet {
 	return map[string]AttributeSet{
-		"changes": {AEChanges, "POST"},
-		"diff":    {AEDiff, "POST"},
+		"changes": {AEChanges, "POST", ""},
+		"diff":    {AEDiff, "POST", ""},
 	}
 }
 

lib/dispatch.go

@@ -48,7 +48,9 @@ type MethodSet interface {
 // Each method is required to have associated attributes in order to successfully register
 type AttributeSet struct {
 	endpoint APIEndpoint
-	verb     string
+	httpVerb string
+	// the default source used for resolving references
+	defaultSource string
 }
 
 // Dispatch is a system for handling calls to lib. Should only be called by top-level lib methods.
@@ -144,6 +146,11 @@ func (inst *Instance) dispatchMethodCall(ctx context.Context, method string, par
 
 	// Look up the method for the given signifier
 	if c, ok := inst.regMethods.lookup(method); ok {
+		// If this method has a default source and no override exists, use that
+		// default instead
+		if source == "" {
+			source = c.Source
+		}
 		// Construct the isolated scope for this call
 		// TODO(dustmop): Add user authentication, profile, identity, etc
 		// TODO(dustmop): Also determine if the method is read-only vs read-write,
@@ -237,12 +244,14 @@ type callable struct {
 	RetCursor bool
 	Endpoint  APIEndpoint
 	Verb      string
+	Source    string
 }
 
 // RegisterMethods iterates the methods provided by the lib API, and makes them visible to dispatch
 func (inst *Instance) RegisterMethods() {
 	reg := make(map[string]callable)
 	inst.registerOne("access", inst.Access(), accessImpl{}, reg)
+	inst.registerOne("automation", inst.Automation(), automationImpl{}, reg)
 	inst.registerOne("collection", inst.Collection(), collectionImpl{}, reg)
 	inst.registerOne("config", inst.Config(), configImpl{}, reg)
 	inst.registerOne("dataset", inst.Dataset(), datasetImpl{}, reg)
@@ -255,7 +264,6 @@ func (inst *Instance) RegisterMethods() {
 	inst.registerOne("remote", inst.Remote(), remoteImpl{}, reg)
 	inst.registerOne("search", inst.Search(), searchImpl{}, reg)
 	inst.registerOne("sql", inst.SQL(), sqlImpl{}, reg)
-	inst.registerOne("automation", inst.Automation(), automationImpl{}, reg)
 	inst.regMethods = &regMethodSet{reg: reg}
 }
 
@@ -384,25 +392,13 @@ func (inst *Instance) registerOne(ourName string, methods MethodSet, impl interf
 		// Remove this method from the methodSetMap now that it has been processed
 		delete(methodMap, i.Name)
 
-		var endpoint APIEndpoint
-		var httpVerb string
 		// Additional attributes for the method are found in the Attributes
 		amap := methods.Attributes()
 		methodAttrs, ok := amap[lowerName]
 		if !ok {
 			regFail("not in Attributes: %s.%s", ourName, lowerName)
 		}
-		endpoint = methodAttrs.endpoint
-		httpVerb = methodAttrs.verb
-		// If both these are empty string, RPC is not allowed for this method
-		if endpoint != "" || httpVerb != "" {
-			if !strings.HasPrefix(string(endpoint), "/") {
-				regFail("%s: endpoint URL must start with /, got %q", lowerName, endpoint)
-			}
-			if httpVerb != http.MethodGet && httpVerb != http.MethodPost && httpVerb != http.MethodPut {
-				regFail("%s: unknown http verb, got %q", lowerName, httpVerb)
-			}
-		}
+		validateMethodAttrs(lowerName, methodAttrs)
 
 		// Save the method to the registration table
 		reg[funcName] = callable{
@@ -411,8 +407,9 @@ func (inst *Instance) registerOne(ourName string, methods MethodSet, impl interf
 			InType:    inType,
 			OutType:   outType,
 			RetCursor: returnsCursor,
-			Endpoint:  endpoint,
-			Verb:      httpVerb,
+			Endpoint:  methodAttrs.endpoint,
+			Verb:      methodAttrs.httpVerb,
+			Source:    methodAttrs.defaultSource,
 		}
 		log.Debugf("%d: registered %s(*%s) %v", k, funcName, inType, outType)
 	}
@@ -428,6 +425,30 @@ func regFail(fstr string, vals ...interface{}) {
 	panic(fmt.Sprintf(fstr, vals...))
 }
 
+func validateMethodAttrs(methodName string, attrs AttributeSet) {
+	// If endpoint and verb are not set, then RPC is denied, nothing to validate
+	// TODO(dustmop): Technically this is denying all HTTP, not just RPC. Consider
+	// separating HTTP and RPC denial
+	if attrs.endpoint == "" && attrs.httpVerb == "" {
+		return
+	}
+	if !strings.HasPrefix(string(attrs.endpoint), "/") {
+		regFail("%s: endpoint URL must start with /, got %q", methodName, attrs.endpoint)
+	}
+	if !stringOneOf(attrs.httpVerb, []string{http.MethodGet, http.MethodPost, http.MethodPut}) {
+		regFail("%s: unknown http verb, got %q", methodName, attrs.httpVerb)
+	}
+}
+
+func stringOneOf(needle string, haystack []string) bool {
+	for _, each := range haystack {
+		if needle == each {
+			return true
+		}
+	}
+	return false
+}
+
 func (inst *Instance) buildMethodMap(impl interface{}) map[string]reflect.Method {
 	result := make(map[string]reflect.Method)
 	implType := reflect.TypeOf(impl)