Add target_link_options_shared_lib to coremldelegate build (#3556)

swolchok · facebook-github-bot · commit c83af25b7625 · 2024-05-10T10:12:06.000-07:00
Summary: Backends use a static initializer to register themselves. We have an established solution to forcing the Apple linker to load the object files containing said initializer, so let's use it for CoreML. Pull Request resolved: #3556 Test Plan: Attempt to load a CoreML PTE from Python no longer fails with error about the backend not being registered Reviewed By: mikekgfb Differential Revision: D57136490 Pulled By: swolchok fbshipit-source-id: 613d7f786fa47f34a94ee4eea7b2a81ef670a573
diff --git a/backends/apple/coreml/CMakeLists.txt b/backends/apple/coreml/CMakeLists.txt
@@ -155,6 +155,8 @@ target_link_libraries(
           ${FOUNDATION_FRAMEWORK} ${SQLITE_LIBRARY}
 )
 
+target_link_options_shared_lib(coremldelegate)
+
 if(COREML_BUILD_EXECUTOR_RUNNER)
   target_link_libraries(
     coremldelegate PRIVATE portable_ops_lib portable_kernels

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,8 @@ target_link_libraries(`
`155`	`155`	`${FOUNDATION_FRAMEWORK} ${SQLITE_LIBRARY}`
`156`	`156`	`)`
`157`	`157`
	`158`	`+target_link_options_shared_lib(coremldelegate)`
	`159`	`+`
`158`	`160`	`if(COREML_BUILD_EXECUTOR_RUNNER)`
`159`	`161`	`target_link_libraries(`
`160`	`162`	`coremldelegate PRIVATE portable_ops_lib portable_kernels`