Fix version line on Java 10 and later #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitdesire
pushed a commit
to benoitdesire/capsule
that referenced
this pull request
Dec 15, 2020
As in https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Runtime.Version.html Also add fix from puniverse#130 Change-Id: Id166fa885c45248d3baa03c4faec78c1156fbaa9
benoitdesire
pushed a commit
to benoitdesire/capsule
that referenced
this pull request
Dec 15, 2020
As in https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Runtime.Version.html Also add fix from puniverse#130 Change-Id: Id166fa885c45248d3baa03c4faec78c1156fbaa9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue when parsing the version line produced by Java 10 and later. It also adds a small unit test to keep check the regexp is working properly.
Solves #129.