Add the types, test it using Mypy #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef5f30b to
54e6de8
Compare
Closed
Pierre-Sassoulas
approved these changes
Oct 21, 2024
Collaborator
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
A lot to review here, great work, I didn't see anything dodgy but then I took only 15mn for the review. We can probably iterate on it later if there's small mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I do the minimal code change, the biggest is removing the ProfileValidationTool hack in prospector/tools/init.py.
Motivation and Context