Add some more mypy checks

Author: sbrunner

.prospector.yml

@@ -14,8 +14,16 @@ mypy:
   options:
     ignore-missing-imports: true
     follow-imports: skip
+    check-untyped-defs: true
+    disallow-any-generics: true
     disallow-untyped-defs: true
-    #strict: true
+    disallow-incomplete-defs: true
+    disallow-untyped-decorators: true
+    warn-unused-configs: true
+    warn-unused-ignores: true
+    warn-redundant-casts: true
+    warn-return-any: true
+    extra-checks: true
 
 pylint:
   options:

prospector/config/__init__.py

@@ -98,10 +98,11 @@ def replace_deprecated_tool_names(self) -> list[str]:
 
     def get_output_report(self) -> list[tuple[str, list[str]]]:
         # Get the output formatter
+        output_report: list[tuple[str, list[str]]]
         if self.config.output_format is not None:
             output_report = self.config.output_format
         else:
-            output_report = [(self.profile.output_format, self.profile.output_target)]
+            output_report = [(self.profile.output_format, self.profile.output_target)]  # type: ignore[list-item]
 
         for index, report in enumerate(output_report):
             if not all(report):
@@ -262,7 +263,7 @@ def _determine_tool_runners(self, config: setoptconf.config.Configuration, profi
 
     def _determine_ignores(
         self, config: setoptconf.config.Configuration, profile: ProspectorProfile, libraries: list[str]
-    ) -> list[re.Pattern]:
+    ) -> list[re.Pattern[str]]:
         # Grab ignore patterns from the options
         ignores = []
         for pattern in config.ignore_patterns + profile.ignore_patterns:
@@ -300,7 +301,7 @@ def get_summary_information(self) -> dict[str, Any]:
         }
 
     def exit_with_zero_on_success(self) -> bool:
-        return self.config.zero_exit
+        return self.config.zero_exit  # type: ignore[no-any-return]
 
     def get_disabled_messages(self, tool_name: str) -> list[str]:
         return self.profile.get_disabled_messages(tool_name)
@@ -314,51 +315,51 @@ def tool_options(self, tool_name: str) -> dict[str, str]:
         tool = getattr(self.profile, tool_name, None)
         if tool is None:
             return {}
-        return tool.get("options", {})
+        return tool.get("options", {})  # type: ignore[no-any-return]
 
     def external_config_location(self, tool_name: str) -> Optional[Path]:
         return getattr(self.config, "%s_config_file" % tool_name, None)
 
     @property
     def die_on_tool_error(self) -> bool:
-        return self.config.die_on_tool_error
+        return self.config.die_on_tool_error  # type: ignore[no-any-return]
 
     @property
     def summary_only(self) -> bool:
-        return self.config.summary_only
+        return self.config.summary_only  # type: ignore[no-any-return]
 
     @property
     def messages_only(self) -> bool:
-        return self.config.messages_only
+        return self.config.messages_only  # type: ignore[no-any-return]
 
     @property
     def quiet(self) -> bool:
-        return self.config.quiet
+        return self.config.quiet  # type: ignore[no-any-return]
 
     @property
     def blending(self) -> bool:
-        return self.config.blending
+        return self.config.blending  # type: ignore[no-any-return]
 
     @property
     def absolute_paths(self) -> bool:
-        return self.config.absolute_paths
+        return self.config.absolute_paths  # type: ignore[no-any-return]
 
     @property
     def max_line_length(self) -> int:
-        return self.config.max_line_length
+        return self.config.max_line_length  # type: ignore[no-any-return]
 
     @property
     def include_tool_stdout(self) -> bool:
-        return self.config.include_tool_stdout
+        return self.config.include_tool_stdout  # type: ignore[no-any-return]
 
     @property
     def direct_tool_stdout(self) -> bool:
-        return self.config.direct_tool_stdout
+        return self.config.direct_tool_stdout  # type: ignore[no-any-return]
 
     @property
     def show_profile(self) -> bool:
-        return self.config.show_profile
+        return self.config.show_profile  # type: ignore[no-any-return]
 
     @property
     def legacy_tool_names(self) -> bool:
-        return self.config.legacy_tool_names
+        return self.config.legacy_tool_names  # type: ignore[no-any-return]

prospector/finder.py

@@ -18,7 +18,7 @@ class FileFinder:
     is basically to know which files to pass to which tools to be inspected.
     """
 
-    def __init__(self, *provided_paths: Path, exclusion_filters: Optional[Iterable[Callable]] = None):
+    def __init__(self, *provided_paths: Path, exclusion_filters: Optional[Iterable[Callable[[Path], bool]]] = None):
         """
         :param provided_paths:
             A list of Path objects to search for files and modules - can be either directories or files

prospector/profiles/__init__.py

@@ -1,4 +1,4 @@
-from pathlib import Path
+from pathlib import Path  # pylint: disable=cyclic-import
 
 AUTO_LOADED_PROFILES = list(
     Path(*parts)

prospector/profiles/profile.py

@@ -58,7 +58,7 @@ def get_disabled_messages(self, tool_name: str) -> list[str]:
         return list(set(disable) - set(enable))
 
     def is_tool_enabled(self, name: str) -> bool:
-        enabled = getattr(self, name).get("run")
+        enabled: Optional[bool] = getattr(self, name).get("run")
         if enabled is not None:
             return enabled
         # this is not explicitly enabled or disabled, so use the default

prospector/run.py

@@ -182,7 +182,7 @@ def get_parser() -> argparse.ArgumentParser:
     """
     manager = cfg.build_manager()
     source = cfg.build_command_line_source(prog="prospector", description=None)
-    return source.build_parser(manager.settings, None)
+    return source.build_parser(manager.settings, None)  # type: ignore[no-any-return]
 
 
 def main() -> None:

prospector/tools/mypy/__init__.py

@@ -45,7 +45,9 @@ def format_message(message: str) -> Message:
     )
 
 
-def _run_in_subprocess(q: Queue, cmd: Callable[[list[str]], tuple[str, str]], paths: list[str]) -> None:
+def _run_in_subprocess(
+    q: "Queue[tuple[str, str]]", cmd: Callable[[list[str]], tuple[str, str]], paths: list[str]
+) -> None:
     """
     This function exists only to be called by multiprocessing.Process as using
     lambda is forbidden

prospector/tools/profile_validator/__init__.py

@@ -62,7 +62,7 @@ def __init__(self) -> None:
         self.ignore_codes: list[str] = []
 
     def configure(self, prospector_config: "ProspectorConfig", found_files: FileFinder) -> None:
-        for profile in prospector_config.config.profiles:  # type: ignore[attr-defined]
+        for profile in prospector_config.config.profiles:
             self.to_check.add(profile)
 
         self.ignore_codes = prospector_config.get_disabled_messages("profile-validator")

prospector/tools/pycodestyle/__init__.py

@@ -152,7 +152,7 @@ def configure(
     def run(self, _: Any) -> list[Message]:
         assert self.checker is not None
         report = self.checker.check_files()
-        return report.get_messages()
+        return report.get_messages()  # type: ignore[no-any-return]
 
 
 # Load pep8ext_naming into pycodestyle's configuration.