Skip to content

Commit f66f2e4

Browse files
committed
Update .coderabbit.yaml to disable auto review and adjust path filters; enhance validation logic by including special columns in validation functions and record builders.
1 parent 2d3e9ab commit f66f2e4

4 files changed

Lines changed: 11 additions & 8 deletions

File tree

.coderabbit.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
reviews:
55
# Enable automated review for pull requests
66
auto_review:
7-
enabled: true
7+
enabled: false
88
base_branches:
99
- ".*" # Matches all branches using regex
1010
review_status: false
1111
poem: false
12-
13-
path_filters:
14-
- "!apps/demo/**" # exclude the demo app from reivews
12+
high_level_summary: false
13+
path_filters:
14+
- "!apps/demo/**" # exclude the demo app from reivews

packages/fmodata/src/client/query/query-builder.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -897,6 +897,7 @@ export class QueryBuilder<
897897
expandConfigs: this.expandConfigs,
898898
skipValidation: options?.skipValidation,
899899
useEntityIds: mergedOptions.useEntityIds,
900+
includeSpecialColumns: mergedOptions.includeSpecialColumns,
900901
fieldMapping: this.fieldMapping,
901902
logger: this.logger,
902903
});

packages/fmodata/src/client/record-builder.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -781,10 +781,7 @@ export class RecordBuilder<
781781
}
782782

783783
// Use shared response processor
784-
const mergedOptions = mergeExecuteOptions(
785-
options,
786-
this.databaseUseEntityIds,
787-
);
784+
const mergedOptions = this.mergeExecuteOptions(options);
788785
const expandBuilder = new ExpandBuilder(
789786
mergedOptions.useEntityIds ?? false,
790787
this.logger,
@@ -801,6 +798,7 @@ export class RecordBuilder<
801798
expandValidationConfigs,
802799
skipValidation: options?.skipValidation,
803800
useEntityIds: mergedOptions.useEntityIds,
801+
includeSpecialColumns: mergedOptions.includeSpecialColumns,
804802
fieldMapping: this.fieldMapping,
805803
});
806804
}

packages/fmodata/src/validation.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@ export async function validateRecord<T extends Record<string, any>>(
258258
expandConfig.targetSchema,
259259
expandConfig.selectedFields as string[] | undefined,
260260
expandConfig.nestedExpands,
261+
includeSpecialColumns,
261262
);
262263
if (!itemValidation.valid) {
263264
return {
@@ -282,6 +283,7 @@ export async function validateRecord<T extends Record<string, any>>(
282283
expandConfig.targetSchema,
283284
expandConfig.selectedFields as string[] | undefined,
284285
expandConfig.nestedExpands,
286+
includeSpecialColumns,
285287
);
286288
if (!itemValidation.valid) {
287289
return {
@@ -408,6 +410,7 @@ export async function validateRecord<T extends Record<string, any>>(
408410
expandConfig.targetSchema,
409411
expandConfig.selectedFields as string[] | undefined,
410412
expandConfig.nestedExpands,
413+
includeSpecialColumns,
411414
);
412415
if (!itemValidation.valid) {
413416
return {
@@ -432,6 +435,7 @@ export async function validateRecord<T extends Record<string, any>>(
432435
expandConfig.targetSchema,
433436
expandConfig.selectedFields as string[] | undefined,
434437
expandConfig.nestedExpands,
438+
includeSpecialColumns,
435439
);
436440
if (!itemValidation.valid) {
437441
return {

0 commit comments

Comments
 (0)