Skip to content

Add AbsCaptureTimeExtension and PlayoutDelayExtension#196

Merged
kevmo314 merged 1 commit into
masterfrom
headerext
Aug 2, 2022
Merged

Add AbsCaptureTimeExtension and PlayoutDelayExtension#196
kevmo314 merged 1 commit into
masterfrom
headerext

Conversation

@kevmo314

Copy link
Copy Markdown
Contributor

Both of these are experimental RTP header extensions defined in
libwebrtc.

@kevmo314 kevmo314 requested a review from mengelbart July 29, 2022 22:26
@codecov

codecov Bot commented Jul 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #196 (7e03423) into master (9a6e1d0) will increase coverage by 0.23%.
The diff coverage is 94.82%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   87.36%   87.60%   +0.23%     
==========================================
  Files          18       20       +2     
  Lines        1773     1831      +58     
==========================================
+ Hits         1549     1604      +55     
- Misses        195      197       +2     
- Partials       29       30       +1     
Flag Coverage Δ
go 87.60% <94.82%> (+0.23%) ⬆️
wasm 86.61% <94.82%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
abscapturetimeextension.go 92.85% <92.85%> (ø)
playoutdelayextension.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6e1d0...7e03423. Read the comment docs.

@kevmo314 kevmo314 force-pushed the headerext branch 3 times, most recently from 45be975 to 2b09f2b Compare July 29, 2022 22:30
@kevmo314 kevmo314 force-pushed the headerext branch 2 times, most recently from 05ee9fc to 3bb9d6d Compare July 29, 2022 22:43
Comment thread abscapturetimeextension.go Outdated
Comment thread playoutdelayextension.go Outdated
Add AbsCaptureTimeExtension and PlayoutDelayExtension implementations.
Both of these are experimental RTP header extensions defined in
libwebrtc.

@mengelbart mengelbart left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@kevmo314 kevmo314 merged commit 0bd9553 into master Aug 2, 2022
@stv0g stv0g deleted the headerext branch May 22, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants