Fix wrong fee calculation for Monerium to Evm onramp#1077
Merged
ebma merged 1 commit intoFeb 20, 2026
Merged
Conversation
…ith zero fee handling
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect fee calculation for Monerium to EVM onramps by ensuring that vortex and partner markup fees are not applied to these transactions. The implementation introduces an optional fee override mechanism that allows specific fee engines to explicitly set these fees to zero.
Changes:
- Added optional
forcedVortexFeeandforcedPartnerMarkupFeefields to theFeeComputationinterface - Updated
BaseFeeEngine.execute()to use forced fees when provided, falling back to calculated fees otherwise - Modified
OnRampMoneriumToEvmFeeEngineto set both forced fees to zero, preventing any vortex or partner markup charges
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/api/src/api/services/quote/engines/fee/index.ts | Added optional forced fee fields to FeeComputation interface and updated fee assignment logic to use forced fees when present |
| apps/api/src/api/services/quote/engines/fee/onramp-monerium-to-evm.ts | Set forcedVortexFee and forcedPartnerMarkupFee to zero to ensure no vortex or partner markup fees are charged |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that no vortex or partner markup fee is applied for Monerium to Evm onramps.
Closes #1047.