Add parallel balance check by gianfra-t · Pull Request #1041 · pendulum-chain/vortex

gianfra-t · 2026-01-26T20:09:11Z

No description provided.

netlify · 2026-01-26T20:09:17Z

✅ Deploy Preview for vortexfi ready!

Name	Link
🔨 Latest commit	`6da1671`
🔍 Latest deploy log	https://app.netlify.com/projects/vortexfi/deploys/6977d2ba63929f00086a8bd8
😎 Deploy Preview	https://deploy-preview-1041--vortexfi.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-01-26T20:09:17Z

✅ Deploy Preview for vortex-sandbox ready!

Name	Link
🔨 Latest commit	`6da1671`
🔍 Latest deploy log	https://app.netlify.com/projects/vortex-sandbox/deploys/6977d2ba28eead000871ff75
😎 Deploy Preview	https://deploy-preview-1041--vortex-sandbox.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

This pull request adds a parallel balance check optimization to the SquidRouter pay phase handler. The goal is to reduce wait times by checking both the Axelar bridge status and the destination balance concurrently, succeeding as soon as either check passes.

Changes:

Added imports for balance checking utilities and EVM-specific types
Introduced new constants for balance check polling intervals and timeouts
Created a new checkStatus method that runs balance and bridge status checks in parallel using Promise.any
Renamed the original checkStatus method to checkBridgeStatus

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-26T20:20:58Z

+    let balanceCheckPromise: Promise<any>;
+
+    try {
+      const outTokenDetails = getOnChainTokenDetails(toChain, quote.outputCurrency as any) as EvmTokenDetails;


The type casting quote.outputCurrency as any bypasses type safety. Consider using a more specific type guard or assertion to ensure quote.outputCurrency is of the expected type for getOnChainTokenDetails.

Suggested change

const outTokenDetails = getOnChainTokenDetails(toChain, quote.outputCurrency as any) as EvmTokenDetails;

const outTokenDetails = getOnChainTokenDetails(toChain, quote.outputCurrency as FiatToken) as EvmTokenDetails;

Copilot · 2026-01-26T20:20:59Z

 const AXELAR_POLLING_INTERVAL_MS = 10000; // 10 seconds
 const SQUIDROUTER_INITIAL_DELAY_MS = 60000; // 60 seconds
 const AXL_GAS_SERVICE_EVM = "0x2d5d7d31F671F86C782533cc367F14109a082712";
+const BALANCE_POLLING_TIME_MS = 10000;


The EVM_BALANCE_CHECK_TIMEOUT_MS is set to 15 minutes, which is significantly longer than similar balance checks in other handlers (3-5 minutes in destination-transfer-handler.ts, final-settlement-subsidy.ts, brla-onramp-mint-handler.ts, and monerium-onramp-mint-handler.ts). While this may be intentional for bridge operations which can take longer, consider documenting why this longer timeout is necessary to justify the deviation from the established pattern.

Suggested change

const BALANCE_POLLING_TIME_MS = 10000;

const BALANCE_POLLING_TIME_MS = 10000;

// NOTE: This timeout is intentionally longer (15 minutes) than the 3–5 minute balance

// checks in other handlers. For SquidRouter/Axelar bridge flows we wait for cross-chain

// settlement and gas payment on the destination chain, which can legitimately take longer

// under network congestion or bridge delays. Reducing this timeout risks premature failure

// of otherwise successful bridge operations.

Copilot · 2026-01-26T20:20:59Z

+    }
+
+    try {
+      await Promise.any([this.checkBridgeStatus(state, swapHash, quote), balanceCheckPromise]);


Using Promise.any means that when one promise resolves, the other continues running in the background without supervision. If the balance check succeeds first and checkBridgeStatus later throws an error, this could result in an unhandled promise rejection. Consider using Promise.race with proper cleanup, or ensure that both promises never reject after the other has resolved. Alternatively, add error handling to suppress errors from the "losing" promise after one succeeds.

Copilot · 2026-01-26T20:21:00Z

+  /**
+   * Checks the status of the Axelar bridge and balances in parallel.
+   * If a balance arrived, we consider it a success.
+   * If the bridge reports success, we consider it a success.
+   * Only if both fail (timeout)  we throw.
+   */
+  private async checkStatus(state: RampState, swapHash: string, quote: QuoteTicket): Promise<void> {


The type casting quote.to as EvmNetworks assumes that quote.to is always an EVM network, but there's no validation to ensure this. If quote.to is not an EVM network (e.g., AssetHub or another non-EVM network), the balance check will fail. Consider adding validation to ensure quote.to is an EVM network before proceeding, or handle the case where it's not.

Suggested change

/**

* Checks the status of the Axelar bridge and balances in parallel.

* If a balance arrived, we consider it a success.

* If the bridge reports success, we consider it a success.

* Only if both fail (timeout) we throw.

*/

private async checkStatus(state: RampState, swapHash: string, quote: QuoteTicket): Promise<void> {

/**

* Type guard to determine whether a given network is an EVM network.

* This prevents using EVM-specific utilities with non-EVM destinations (e.g., AssetHub).

*/

private isEvmNetwork(network: Networks | string): network is EvmNetworks {

return Object.values(EvmNetworks).includes(network as EvmNetworks);

}

/**

* Checks the status of the Axelar bridge and balances in parallel.

* If a balance arrived, we consider it a success.

* If the bridge reports success, we consider it a success.

* Only if both fail (timeout) we throw.

*/

private async checkStatus(state: RampState, swapHash: string, quote: QuoteTicket): Promise<void> {

// If the destination is not an EVM network, skip the EVM balance optimization and rely on bridge status only.

if (!this.isEvmNetwork(quote.to as Networks | string)) {

logger.info(

"SquidRouterPayPhaseHandler: Destination network is non-EVM; skipping EVM balance check optimization.",

{ toNetwork: quote.to }

);

await this.checkBridgeStatus(state, swapHash, quote);

return;

}

Copilot · 2026-01-26T20:21:00Z

+  private async checkStatus(state: RampState, swapHash: string, quote: QuoteTicket): Promise<void> {
+    const toChain = quote.to as EvmNetworks;
+
+    let balanceCheckPromise: Promise<any>;


The balanceCheckPromise variable is declared with type Promise<any> which loses type safety. The checkEvmBalancePeriodically function returns Promise<Big>, so this should be typed as Promise<Big> instead.

Suggested change

let balanceCheckPromise: Promise<any>;

let balanceCheckPromise: Promise<Big>;

Copilot · 2026-01-26T20:21:00Z

+        logger.warn(
+          "SquidRouterPayPhaseHandler: Cannot perform balance check optimization (missing expected token details or address)."
+        );
+        balanceCheckPromise = Promise.reject("Skipped balance check");


The balance check promise is rejected with a plain string "Skipped balance check" instead of a proper Error object. This is inconsistent with the error handling elsewhere and makes it harder to debug. Consider using Promise.reject(new Error("Skipped balance check")) instead.

Suggested change

balanceCheckPromise = Promise.reject("Skipped balance check");

balanceCheckPromise = Promise.reject(new Error("Skipped balance check"));

Copilot · 2026-01-26T20:21:00Z

+   * Checks the status of the Axelar bridge and balances in parallel.
+   * If a balance arrived, we consider it a success.
+   * If the bridge reports success, we consider it a success.
+   * Only if both fail (timeout)  we throw.


There's a typo in the comment: "Only if both fail (timeout) we throw." has two spaces before "we throw". This should be a single space.

Suggested change

* Only if both fail (timeout) we throw.

* Only if both fail (timeout) we throw.

Copilot · 2026-01-26T20:21:01Z

+    try {
+      await Promise.any([this.checkBridgeStatus(state, swapHash, quote), balanceCheckPromise]);
+    } catch (error) {
+      // Both failed.
+      if (error instanceof AggregateError) {
+        throw new Error(
+          `SquidRouterPayPhaseHandler: Both bridge status check and balance check failed. Errors: ${error.errors
+            .map(e => (e instanceof Error ? e.message : String(e)))
+            .join(", ")}`
+        );
+      }
+      throw error;
+    }


The error handling in the new checkStatus method doesn't handle BalanceCheckError specifically, unlike other handlers in the codebase (e.g., brla-onramp-mint-handler.ts and monerium-onramp-mint-handler.ts). These handlers distinguish between timeout and read failure errors from checkEvmBalancePeriodically. When both the balance check and bridge status check fail, the error message could be more meaningful if it distinguished between a balance check timeout (expected behavior if bridge is slow) and a balance check read failure (unexpected infrastructure issue).

ebma · 2026-01-26T20:23:43Z

@copilot please address all the unresolved comments from this thread in a separate PR.

Copilot · 2026-01-26T20:23:52Z

@ebma I've opened a new pull request, #1042, to work on those changes. Once the pull request is ready, I'll request review from you.

- Add BalanceCheckError imports for proper error handling - Document 15-minute timeout rationale for bridge flows - Add isEvmNetwork type guard to validate EVM destinations - Fix type safety: balanceCheckPromise is Promise<Big> - Fix type safety: quote.outputCurrency as FiatToken - Use Error objects for rejected promises - Fix typo in comment (double space) - Handle Promise.any unhandled rejections with .catch() - Distinguish BalanceCheckError timeout vs read failure in error messages Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>

Fix type safety and error handling in parallel balance check

add parallel balance check

9aaf065

ebma self-requested a review January 26, 2026 20:10

ebma approved these changes Jan 26, 2026

View reviewed changes

ebma requested a review from Copilot January 26, 2026 20:15

Copilot started reviewing on behalf of ebma January 26, 2026 20:15 View session

Copilot AI reviewed Jan 26, 2026

View reviewed changes

Initial plan

34ec9a1

Copilot AI mentioned this pull request Jan 26, 2026

Fix type safety and error handling in parallel balance check #1042

Merged

Copilot AI and others added 3 commits January 26, 2026 20:26

Merge pull request #1042 from pendulum-chain/copilot/sub-pr-1041

7ac8fda

Fix type safety and error handling in parallel balance check

fix type issues

6da1671

gianfra-t merged commit 3676142 into staging Jan 26, 2026
5 checks passed

ebma deleted the add-parallel-checks-squidrouterpay branch January 26, 2026 20:52

	const outTokenDetails = getOnChainTokenDetails(toChain, quote.outputCurrency as any) as EvmTokenDetails;
	const outTokenDetails = getOnChainTokenDetails(toChain, quote.outputCurrency as FiatToken) as EvmTokenDetails;

-const BALANCE_POLLING_TIME_MS = 10000;
+const BALANCE_POLLING_TIME_MS = 10000;
+// NOTE: This timeout is intentionally longer (15 minutes) than the 3–5 minute balance
+// checks in other handlers. For SquidRouter/Axelar bridge flows we wait for cross-chain
+// settlement and gas payment on the destination chain, which can legitimately take longer
+// under network congestion or bridge delays. Reducing this timeout risks premature failure
+// of otherwise successful bridge operations.

	let balanceCheckPromise: Promise<any>;
	let balanceCheckPromise: Promise<Big>;

	balanceCheckPromise = Promise.reject("Skipped balance check");
	balanceCheckPromise = Promise.reject(new Error("Skipped balance check"));

	* Only if both fail (timeout) we throw.
	* Only if both fail (timeout) we throw.

Conversation

gianfra-t commented Jan 26, 2026

Uh oh!

netlify Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vortexfi ready!

Uh oh!

netlify Bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vortex-sandbox ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

ebma commented Jan 26, 2026

Uh oh!

Copilot AI commented Jan 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify Bot commented Jan 26, 2026 •

edited

Loading

netlify Bot commented Jan 26, 2026 •

edited

Loading