From dd5ddbfe01bcfdfa39ce966c5380334ea781b51f Mon Sep 17 00:00:00 2001 From: evwilkin Date: Tue, 30 Nov 2021 16:58:06 -0500 Subject: [PATCH 1/2] fix(popover): forwarded focus to close button with VoiceOver click --- .../src/components/Popover/Popover.tsx | 20 +------------------ 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/packages/react-core/src/components/Popover/Popover.tsx b/packages/react-core/src/components/Popover/Popover.tsx index a222a02a124..6639ba58969 100644 --- a/packages/react-core/src/components/Popover/Popover.tsx +++ b/packages/react-core/src/components/Popover/Popover.tsx @@ -334,23 +334,6 @@ export const Popover: React.FunctionComponent = ({ } } }; - const onTriggerEnter = (event: KeyboardEvent) => { - if (event.keyCode === KEY_CODES.ENTER) { - if (!visible) { - if (triggerManually) { - shouldOpen(show, event); - } else { - show(true); - } - } else { - if (triggerManually) { - shouldClose(null, hide, event); - } else { - hide(); - } - } - } - }; const onTriggerClick = (event: MouseEvent) => { if (triggerManually) { if (visible) { @@ -362,7 +345,7 @@ export const Popover: React.FunctionComponent = ({ if (visible) { hide(); } else { - show(); + show(true); } } }; @@ -451,7 +434,6 @@ export const Popover: React.FunctionComponent = ({ distance={distance} placement={position} onTriggerClick={onTriggerClick} - onTriggerEnter={onTriggerEnter} onDocumentClick={onDocumentClick} onDocumentKeyDown={onDocumentKeyDown} enableFlip={enableFlip} From 7a9eae6b00fb153795ae80316038ee6a16b9250c Mon Sep 17 00:00:00 2001 From: evwilkin Date: Tue, 30 Nov 2021 20:27:38 -0500 Subject: [PATCH 2/2] updated snapshots --- .../__tests__/Generated/__snapshots__/Popover.test.tsx.snap | 1 - .../Popover/__tests__/__snapshots__/Popover.test.tsx.snap | 4 ---- 2 files changed, 5 deletions(-) diff --git a/packages/react-core/src/components/Popover/__tests__/Generated/__snapshots__/Popover.test.tsx.snap b/packages/react-core/src/components/Popover/__tests__/Generated/__snapshots__/Popover.test.tsx.snap index 7801dcef717..02ab6279706 100644 --- a/packages/react-core/src/components/Popover/__tests__/Generated/__snapshots__/Popover.test.tsx.snap +++ b/packages/react-core/src/components/Popover/__tests__/Generated/__snapshots__/Popover.test.tsx.snap @@ -27,7 +27,6 @@ exports[`Popover should match snapshot (auto-generated) 1`] = ` onDocumentClick={[Function]} onDocumentKeyDown={[Function]} onTriggerClick={[Function]} - onTriggerEnter={[Function]} placement="top" popper={