Skip to content

Commit 38d699d

Browse files
jclery-passxordoquy
authored andcommitted
(PC-32484)[PRO] fix: Adds forgotten feature flag to PC-30946 and PC-31468 !
1 parent 686c38b commit 38d699d

File tree

2 files changed

+45
-31
lines changed

2 files changed

+45
-31
lines changed

pro/src/pages/VenueSettings/VenueSettingsForm.tsx

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { resetAddressFields } from 'components/IndividualOfferForm/utils/resetAd
1414
import { RouteLeavingGuardIndividualOffer } from 'components/RouteLeavingGuardIndividualOffer/RouteLeavingGuardIndividualOffer'
1515
import { ScrollToFirstErrorAfterSubmit } from 'components/ScrollToFirstErrorAfterSubmit/ScrollToFirstErrorAfterSubmit'
1616
import { SelectOption } from 'custom_types/form'
17+
import { useActiveFeature } from 'hooks/useActiveFeature'
1718
import fullBackIcon from 'icons/full-back.svg'
1819
import fullNextIcon from 'icons/full-next.svg'
1920
import { ReimbursementFields } from 'pages/Offerers/Offerer/VenueV1/fields/ReimbursementFields/ReimbursementFields'
@@ -56,6 +57,8 @@ export const VenueSettingsForm = ({
5657
const [manuallySetAddress, , { setValue: setManuallySetAddress }] =
5758
useField('manuallySetAddress')
5859

60+
const isOfferAddressEnabled = useActiveFeature('WIP_ENABLE_OFFER_ADDRESS')
61+
5962
const toggleManuallySetAddress = async () => {
6063
const isAddressManual = !manuallySetAddress.value
6164
await setManuallySetAddress(isAddressManual)
@@ -107,21 +110,27 @@ export const VenueSettingsForm = ({
107110
<AddressSelect disabled={manuallySetAddress.value} />
108111
</FormLayout.Row>
109112

110-
<FormLayout.Row>
111-
<Button
112-
variant={ButtonVariant.QUATERNARY}
113-
title="Renseignez l’adresse manuellement"
114-
icon={manuallySetAddress.value ? fullBackIcon : fullNextIcon}
115-
onClick={toggleManuallySetAddress}
116-
>
117-
{manuallySetAddress.value ? (
118-
<>Revenir à la sélection automatique</>
119-
) : (
120-
<>Vous ne trouvez pas votre adresse ?</>
121-
)}
122-
</Button>
123-
</FormLayout.Row>
124-
{manuallySetAddress.value && <AddressManual />}
113+
{isOfferAddressEnabled && (
114+
<>
115+
<FormLayout.Row>
116+
<Button
117+
variant={ButtonVariant.QUATERNARY}
118+
title="Renseignez l’adresse manuellement"
119+
icon={
120+
manuallySetAddress.value ? fullBackIcon : fullNextIcon
121+
}
122+
onClick={toggleManuallySetAddress}
123+
>
124+
{manuallySetAddress.value ? (
125+
<>Revenir à la sélection automatique</>
126+
) : (
127+
<>Vous ne trouvez pas votre adresse ?</>
128+
)}
129+
</Button>
130+
</FormLayout.Row>
131+
{manuallySetAddress.value && <AddressManual />}
132+
</>
133+
)}
125134
</>
126135
)}
127136
</FormLayout.Section>

pro/src/pages/VenueSettings/VenueSettingsScreen.tsx

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import { GET_VENUE_QUERY_KEY } from 'config/swrQueryKeys'
1717
import { Events } from 'core/FirebaseEvents/constants'
1818
import { PATCH_SUCCESS_MESSAGE } from 'core/shared/constants'
1919
import { SelectOption } from 'custom_types/form'
20+
import { useActiveFeature } from 'hooks/useActiveFeature'
2021
import { useCurrentUser } from 'hooks/useCurrentUser'
2122
import { useNotification } from 'hooks/useNotification'
2223
import fullBackIcon from 'icons/full-back.svg'
@@ -63,6 +64,8 @@ export const VenueSettingsScreen = ({
6364
const [isAddressChangeDialogOpen, setIsAddressChangeDialogOpen] =
6465
useState(false)
6566

67+
const isOfferAddressEnabled = useActiveFeature('WIP_ENABLE_OFFER_ADDRESS')
68+
6669
const handleCancelWithdrawalDialog = () => {
6770
setShouldSendMail(false)
6871
formik.handleSubmit()
@@ -128,7 +131,7 @@ export const VenueSettingsScreen = ({
128131
const onSubmit = async (values: VenueSettingsFormValues) => {
129132
if (
130133
(values.isWithdrawalAppliedOnAllOffers && !handleWithdrawalDialog()) ||
131-
!handleDialogAddressChange()
134+
(!handleDialogAddressChange() && isOfferAddressEnabled)
132135
) {
133136
return
134137
}
@@ -236,21 +239,23 @@ export const VenueSettingsScreen = ({
236239
title="Souhaitez-vous prévenir les bénéficiaires de la modification des modalités de retrait ?"
237240
open={isWithdrawalDialogOpen}
238241
/>
239-
<ConfirmDialog
240-
cancelText="Annuler"
241-
confirmText="Confirmer le changement d'adresse"
242-
leftButtonAction={handleCancelAddressChangeDialog}
243-
onCancel={() => setIsAddressChangeDialogOpen(false)}
244-
onConfirm={handleConfirmAddressChangeDialog}
245-
icon={strokeErrorIcon}
246-
title="Ce changement d'adresse ne va pas s'impacter sur vos offres"
247-
open={isAddressChangeDialogOpen && venue.hasOffers}
248-
>
249-
<p>
250-
Si vous souhaitez rectifier leur localisation, vous devez les
251-
modifier individuellement.
252-
</p>
253-
</ConfirmDialog>
242+
{isOfferAddressEnabled && (
243+
<ConfirmDialog
244+
cancelText="Annuler"
245+
confirmText="Confirmer le changement d'adresse"
246+
leftButtonAction={handleCancelAddressChangeDialog}
247+
onCancel={() => setIsAddressChangeDialogOpen(false)}
248+
onConfirm={handleConfirmAddressChangeDialog}
249+
icon={strokeErrorIcon}
250+
title="Ce changement d'adresse ne va pas s'impacter sur vos offres"
251+
open={isAddressChangeDialogOpen && venue.hasOffers}
252+
>
253+
<p>
254+
Si vous souhaitez rectifier leur localisation, vous devez les
255+
modifier individuellement.
256+
</p>
257+
</ConfirmDialog>
258+
)}
254259
</FormikProvider>
255260
</>
256261
)

0 commit comments

Comments
 (0)