refactor(yarn2): Simplify extracting the module name

The module name may contain at most one '@'. If it does, the '@' is
always the first character. So, use `startIndex=1` to find the
en marker '@' of the module name.

Signed-off-by: Frank Viernau <[email protected]>

Author: fviernau

plugins/package-managers/node/src/main/kotlin/yarn2/Yarn2DependencyHandler.kt

@@ -84,11 +84,11 @@ internal class Yarn2DependencyHandler(
 internal val PackageInfo.isProject: Boolean get() = value.substringAfterLast("@").startsWith("workspace:")
 
 internal val PackageInfo.moduleName: String get() {
-    val firstComponent = value.substringBefore(":")
     // TODO: Handle patched packages different than non-patched ones.
     // Patch packages have locators as e.g. the following, where the first component ends with "@patch".
     // resolve@patch:resolve@npm%3A1.22.8#optional!builtin<compat/resolve>::version=1.22.8&hash=c3c19d
-    return firstComponent.substringBeforeLast("@")
+    val endIndex = value.indexOf("@", startIndex = 1)
+    return value.take(endIndex)
 }
 
 internal val PackageInfo.moduleId: String get() = buildString {