feat(cocoapods): Improve handling for dependencies with checkout option

The information of podspecs corresponding to dependencies which have a
checkout option has been ignored so far. Unify the code paths, so that
the information from podspecs is always used. This simplifies the code
and might get additional data, such as declared licenses and the source
artifact url. Furthermore, the VCS URL from the checkout option is no
more used as `homepageUrl`, but instead always set to the dedicated
`homepage` field of the podspec. This is more consistent with
integration of other package managers.

Signed-off-by: Frank Viernau <[email protected]>

Author: fviernau

plugins/package-managers/cocoapods/src/funTest/assets/projects/synthetic/external-sources-expected-output.yml

@@ -206,7 +206,7 @@ packages:
   declared_licenses: []
   declared_licenses_processed: {}
   description: ""
-  homepage_url: "https://github.com/MacLabs/MLHudAlert.git"
+  homepage_url: ""
   binary_artifact:
     url: ""
     hash:

plugins/package-managers/cocoapods/src/funTest/assets/projects/synthetic/version-resolution-expected-output.yml

@@ -332,7 +332,7 @@ packages:
   declared_licenses: []
   declared_licenses_processed: {}
   description: ""
-  homepage_url: "https://github.com/matrix-org/matrix-analytics-events.git"
+  homepage_url: ""
   binary_artifact:
     url: ""
     hash:

plugins/package-managers/cocoapods/src/main/kotlin/PodDependencyHandler.kt

@@ -73,25 +73,9 @@ internal class PodDependencyHandler : DependencyHandler<Lockfile.Pod> {
 
     override fun createPackage(dependency: Lockfile.Pod, issues: MutableCollection<Issue>): Package {
         val id = identifierFor(dependency)
-
         val checkoutOption = lockfile.checkoutOptions[dependency.name]
-        if (checkoutOption != null) {
-            val vcs = checkoutOption.toVcsInfo()
-
-            return Package(
-                id = id,
-                declaredLicenses = emptySet(),
-                description = "",
-                homepageUrl = vcs.url,
-                binaryArtifact = RemoteArtifact.EMPTY,
-                sourceArtifact = RemoteArtifact.EMPTY,
-                vcs = checkoutOption.toVcsInfo()
-            )
-        }
-
         val podspec = getPodspec(dependency.name, dependency.version)
-
-        val vcs = podspec?.toVcsInfo().orEmpty()
+        val vcs = checkoutOption?.toVcsInfo() ?: podspec?.toVcsInfo().orEmpty()
 
         return Package(
             id = id,