refactor(analyzer): Simplify getModuleInfo()

The reason why a `Map` is used is for better performance in the caller
logic. So, creating that map better fits into the caller. The function
now also aligns better with its KDoc.

Signed-off-by: Frank Viernau <[email protected]>

Author: fviernau

analyzer/src/main/kotlin/managers/GoMod.kt

@@ -117,7 +117,7 @@ class GoMod(
         val projectDir = definitionFile.parentFile
 
         stashDirectories(projectDir.resolve("vendor")).use { _ ->
-            val moduleInfoForModuleName = getModuleInfos(projectDir)
+            val moduleInfoForModuleName = getModuleInfos(projectDir).associateBy { it.path }
             val graph = getModuleGraph(projectDir, moduleInfoForModuleName)
             val packages = graph.nodes.mapNotNullTo(mutableSetOf()) {
                 moduleInfoForModuleName.getValue(it.name).toPackage()
@@ -262,12 +262,10 @@ class GoMod(
      * Return the list of all modules contained in the dependency tree with resolved versions and the 'replace'
      * directive applied.
      */
-    private fun getModuleInfos(projectDir: File): Map<String, ModuleInfo> {
+    private fun getModuleInfos(projectDir: File): List<ModuleInfo> {
         val list = runGo("list", "-m", "-json", "-buildvcs=false", "all", workingDir = projectDir)
 
-        val moduleInfos = list.stdout.byteInputStream().use { JSON.decodeToSequence<ModuleInfo>(it) }
-
-        return moduleInfos.associateBy { it.path }
+        return list.stdout.byteInputStream().use { JSON.decodeToSequence<ModuleInfo>(it) }.toList()
     }
 
     /**