Skip to content

Commit 3207d1e

Browse files
nnobelissschuberth
authored andcommitted
style(detekt): Enable the "MissingPackageDeclaration" rule
Enable the "MissingPackageDeclaration" rule [1] to ensure that all Kotlin source files have a package declaration. [1]: https://detekt.dev/docs/rules/potential-bugs#missingpackagedeclaration Signed-off-by: Nicolas Nobelis <[email protected]>
1 parent 0057704 commit 3207d1e

File tree

6 files changed

+15
-8
lines changed

6 files changed

+15
-8
lines changed

.detekt.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,11 @@ style:
9494
- kotlinx.html.*
9595
- kotlinx.html.dom.*
9696

97+
potential-bugs:
98+
MissingPackageDeclaration:
99+
active: true
100+
excludes: ["**/GradleModel.kt", "**/build.gradle.kts"]
101+
97102
ORT:
98103
OrtImportOrder:
99104
active: true

advisor/src/funTest/kotlin/OsvFunTest.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* License-Filename: LICENSE
1818
*/
1919

20+
package org.ossreviewtoolkit.advisor
21+
2022
import io.kotest.core.spec.style.StringSpec
2123
import io.kotest.matchers.collections.shouldContainExactlyInAnyOrder
2224
import io.kotest.matchers.shouldBe

clients/osv/src/funTest/kotlin/OsvServiceFunTest.kt

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* License-Filename: LICENSE
1818
*/
1919

20+
package org.ossreviewtoolkit.clients.osv
21+
2022
import io.kotest.core.spec.style.StringSpec
2123
import io.kotest.matchers.collections.shouldContainExactlyInAnyOrder
2224
import io.kotest.matchers.result.shouldBeSuccess
@@ -26,11 +28,6 @@ import java.time.Instant
2628

2729
import kotlinx.serialization.json.JsonObject
2830

29-
import org.ossreviewtoolkit.clients.osv.OsvApiClient
30-
import org.ossreviewtoolkit.clients.osv.OsvService
31-
import org.ossreviewtoolkit.clients.osv.Package
32-
import org.ossreviewtoolkit.clients.osv.VulnerabilitiesForPackageRequest
33-
import org.ossreviewtoolkit.clients.osv.Vulnerability
3431
import org.ossreviewtoolkit.utils.test.getAssetAsString
3532

3633
private val VULNERABILITY_FOR_PACKAGE_BY_COMMIT_REQUEST = VulnerabilitiesForPackageRequest(

clients/scanoss/src/test/kotlin/ScanOssDetailsTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* License-Filename: LICENSE
1818
*/
1919

20+
package org.ossreviewtoolkit.clients.scanoss
21+
2022
import com.github.tomakehurst.wiremock.WireMockServer
2123
import com.github.tomakehurst.wiremock.core.WireMockConfiguration
2224

@@ -34,7 +36,6 @@ import okhttp3.MediaType.Companion.toMediaType
3436
import okhttp3.MultipartBody
3537
import okhttp3.RequestBody.Companion.asRequestBody
3638

37-
import org.ossreviewtoolkit.clients.scanoss.ScanOssService
3839
import org.ossreviewtoolkit.clients.scanoss.model.Source
3940
import org.ossreviewtoolkit.utils.test.shouldNotBeNull
4041

clients/scanoss/src/test/kotlin/ScanOssServiceTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* License-Filename: LICENSE
1818
*/
1919

20+
package org.ossreviewtoolkit.clients.scanoss
21+
2022
import com.github.tomakehurst.wiremock.WireMockServer
2123
import com.github.tomakehurst.wiremock.core.WireMockConfiguration
2224

@@ -33,7 +35,6 @@ import okhttp3.MediaType.Companion.toMediaType
3335
import okhttp3.MultipartBody
3436
import okhttp3.RequestBody.Companion.asRequestBody
3537

36-
import org.ossreviewtoolkit.clients.scanoss.ScanOssService
3738
import org.ossreviewtoolkit.clients.scanoss.model.IdentificationType
3839
import org.ossreviewtoolkit.utils.test.shouldNotBeNull
3940

plugins/package-configuration-providers/ort-config/src/test/kotlin/OrtConfigPackageConfigurationProviderFunTest.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
* License-Filename: LICENSE
1818
*/
1919

20+
package org.ossreviewtoolkit.plugins.packageconfigurationproviders.ortconfig
21+
2022
import io.kotest.core.spec.style.StringSpec
2123
import io.kotest.matchers.collections.beEmpty
2224
import io.kotest.matchers.collections.haveSize
@@ -26,7 +28,6 @@ import org.ossreviewtoolkit.model.ArtifactProvenance
2628
import org.ossreviewtoolkit.model.Hash
2729
import org.ossreviewtoolkit.model.Identifier
2830
import org.ossreviewtoolkit.model.RemoteArtifact
29-
import org.ossreviewtoolkit.plugins.packageconfigurationproviders.ortconfig.OrtConfigPackageConfigurationProvider
3031

3132
class OrtConfigPackageConfigurationProviderFunTest : StringSpec({
3233
"provider can load package-configurations from the ort-config repository" {

0 commit comments

Comments
 (0)