Skip to content

Commit 029f1ca

Browse files
heliocastrotsteenbe
authored andcommitted
chore(docker): Use consistent naming and descriptions
Signed-off-by: Helio Chissini de Castro <[email protected]>
1 parent 8e6fd16 commit 029f1ca

File tree

5 files changed

+52
-48
lines changed

5 files changed

+52
-48
lines changed

.github/actions/ortdocker/action.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@
1515
# SPDX-License-Identifier: Apache-2.0
1616
# License-Filename: LICENSE
1717

18-
name: "ORT Docker Image"
19-
description: "Check and create docker image for Ort components"
20-
author: "Helio Chissini de Castro <[email protected]>"
18+
name: "ORT Docker image"
19+
description: "Check and create Docker image for ORT components"
20+
author: "The ORT Project Authors"
2121

2222
inputs:
2323
registry:
24-
description: "GitHub Container Registry"
24+
description: "GitHub container registry"
2525
default: "ghcr.io"
2626
token:
2727
description: "GitHub token"
@@ -61,19 +61,19 @@ runs:
6161
echo $result
6262
echo "result=$result" >> $GITHUB_OUTPUT
6363
64-
- name: Set up Docker Buildx
64+
- name: Set up Docker build
6565
if: steps.check_image.outputs.result != 'found'
6666
uses: docker/setup-buildx-action@v2
6767

68-
- name: Login to GitHub Container Registry
68+
- name: Login to GitHub container registry
6969
if: steps.check_image.outputs.result != 'found'
7070
uses: docker/login-action@v2
7171
with:
7272
registry: ${{ inputs.registry }}
7373
username: ${{ github.actor }}
7474
password: ${{ inputs.token }}
7575

76-
- name: Extract components metadata (tags, labels) for base image
76+
- name: Extract components metadata (tags, labels)
7777
if: steps.check_image.outputs.result != 'found'
7878
id: meta
7979
uses: docker/metadata-action@v4
@@ -83,7 +83,7 @@ runs:
8383
tags:
8484
type=raw,value=${{ inputs.version }}
8585

86-
- name: Build ORT Base container
86+
- name: Build image
8787
if: steps.check_image.outputs.result != 'found'
8888
uses: docker/build-push-action@v4
8989
with:

.github/actions/ortdocker/check_image.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919

2020
import requests
2121

22+
""" Use current GitHub API to check if a container image with the
23+
given name and version exists.
24+
"""
25+
2226
token = os.getenv("INPUT_TOKEN")
2327
org = os.getenv("GITHUB_REPOSITORY_OWNER")
2428
name = os.getenv("INPUT_NAME")

.github/workflows/docker-ort-runtime-ext.yml

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# SPDX-License-Identifier: Apache-2.0
1616
# License-Filename: LICENSE
1717

18-
name: MegaDocker Extended Image
18+
name: Mega Docker extended image
1919

2020
on:
2121
workflow_dispatch:
@@ -31,7 +31,7 @@ on:
3131
- '*'
3232
workflow_run:
3333
workflows:
34-
- 'MegaDocker Runtime Image'
34+
- 'Mega Docker runtime image'
3535
types:
3636
- completed
3737

@@ -42,15 +42,15 @@ permissions: write-all
4242

4343
jobs:
4444
android_image:
45-
name: Android Image
45+
name: Android image
4646
runs-on: ubuntu-22.04
4747
steps:
4848
- name: Checkout default branch
4949
uses: actions/checkout@v3
5050
- name: Set environment variables
5151
run: |
5252
cat .versions >> $GITHUB_ENV
53-
- name: Build Android Image
53+
- name: Build Android image
5454
uses: ./.github/actions/ortdocker
5555
with:
5656
name: android
@@ -60,15 +60,15 @@ jobs:
6060
ANDROID_CMD_VERSION=${{ env.ANDROID_CMD_VERSION }}
6161
6262
dart_image:
63-
name: Dart Image
63+
name: Dart image
6464
runs-on: ubuntu-22.04
6565
steps:
6666
- name: Checkout default branch
6767
uses: actions/checkout@v3
6868
- name: Set environment variables
6969
run: |
7070
cat .versions >> $GITHUB_ENV
71-
- name: Build Dart Image
71+
- name: Build Dart image
7272
uses: ./.github/actions/ortdocker
7373
with:
7474
name: dart
@@ -78,15 +78,15 @@ jobs:
7878
DART_VERSION=${{ env.DART_VERSION }}
7979
8080
dotnet_image:
81-
name: Dotnet Image
81+
name: Dotnet image
8282
runs-on: ubuntu-22.04
8383
steps:
8484
- name: Checkout default branch
8585
uses: actions/checkout@v3
8686
- name: Set environment variables
8787
run: |
8888
cat .versions >> $GITHUB_ENV
89-
- name: Build Dotnet Image
89+
- name: Build Dotnet image
9090
uses: ./.github/actions/ortdocker
9191
with:
9292
name: dotnet
@@ -97,15 +97,15 @@ jobs:
9797
NUGET_INSPECTOR_VERSION=${{ env.NUGET_INSPECTOR_VERSION }}
9898
9999
haskell_image:
100-
name: Haskell Image
100+
name: Haskell image
101101
runs-on: ubuntu-22.04
102102
steps:
103103
- name: Checkout default branch
104104
uses: actions/checkout@v3
105105
- name: Set environment variables
106106
run: |
107107
cat .versions >> $GITHUB_ENV
108-
- name: Build Haskell Image
108+
- name: Build Haskell image
109109
uses: ./.github/actions/ortdocker
110110
with:
111111
name: haskell
@@ -115,15 +115,15 @@ jobs:
115115
HASKELL_STACK_VERSION=${{ env.HASKELL_STACK_VERSION }}
116116
117117
scala_image:
118-
name: Scala Image
118+
name: Scala image
119119
runs-on: ubuntu-22.04
120120
steps:
121121
- name: Checkout default branch
122122
uses: actions/checkout@v3
123123
- name: Set environment variables
124124
run: |
125125
cat .versions >> $GITHUB_ENV
126-
- name: Build Scala Image
126+
- name: Build Scala image
127127
uses: ./.github/actions/ortdocker
128128
with:
129129
name: scala
@@ -133,15 +133,15 @@ jobs:
133133
SBT_VERSION=${{ env.SBT_VERSION }}
134134
135135
swift_image:
136-
name: Swift Image
136+
name: Swift image
137137
runs-on: ubuntu-22.04
138138
steps:
139139
- name: Checkout default branch
140140
uses: actions/checkout@v3
141141
- name: Set environment variables
142142
run: |
143143
cat .versions >> $GITHUB_ENV
144-
- name: Build Swift Image
144+
- name: Build Swift image
145145
uses: ./.github/actions/ortdocker
146146
with:
147147
name: swift
@@ -152,7 +152,7 @@ jobs:
152152
153153
runtime_extended_image:
154154
if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
155-
name: Build ORT Extended Image
155+
name: Build ORT extended image
156156
needs: [ android_image, dart_image, dotnet_image, haskell_image, scala_image, swift_image ]
157157
runs-on: ubuntu-22.04
158158
permissions:
@@ -163,17 +163,17 @@ jobs:
163163
- name: Checkout default branch
164164
uses: actions/checkout@v3
165165

166-
- name: Set up Docker Buildx
166+
- name: Set up Docker build
167167
uses: docker/setup-buildx-action@v2
168168

169-
- name: Login to GitHub Container Registry
169+
- name: Login to GitHub container registry
170170
uses: docker/login-action@v2
171171
with:
172172
registry: ${{ env.REGISTRY }}
173173
username: ${{ github.actor }}
174174
password: ${{ secrets.GITHUB_TOKEN }}
175175

176-
- name: Extract components metadata (tags, labels) for Ort runtime image
176+
- name: Extract components metadata (tags, labels)
177177
id: meta-ort
178178
uses: docker/metadata-action@v4
179179
with:
@@ -182,7 +182,7 @@ jobs:
182182
tags: |
183183
type=raw,sha,enable=true,format=short
184184
185-
- name: Build ORT runtime container
185+
- name: Build ORT extended runtime image
186186
uses: docker/build-push-action@v4
187187
with:
188188
context: .

.github/workflows/docker-ort-runtime.yml

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# SPDX-License-Identifier: Apache-2.0
1616
# License-Filename: LICENSE
1717

18-
name: MegaDocker Runtime Image
18+
name: Mega Docker runtime image
1919

2020
on:
2121
workflow_dispatch:
@@ -36,15 +36,15 @@ permissions: write-all
3636

3737
jobs:
3838
base_image:
39-
name: Base Image
39+
name: Base image
4040
runs-on: ubuntu-22.04
4141
steps:
4242
- name: Checkout default branch
4343
uses: actions/checkout@v3
4444
- name: Set environment variables
4545
run: |
4646
cat .versions >> $GITHUB_ENV
47-
- name: Build Base Image
47+
- name: Build base image
4848
uses: ./.github/actions/ortdocker
4949
with:
5050
name: base
@@ -55,7 +55,7 @@ jobs:
5555
UBUNTU_VERSION=${{ env.UBUNTU_VERSION }}
5656
5757
nodejs_image:
58-
name: NodeJS Image
58+
name: NodeJS image
5959
needs: [base_image]
6060
runs-on: ubuntu-22.04
6161
steps:
@@ -64,7 +64,7 @@ jobs:
6464
- name: Set environment variables
6565
run: |
6666
cat .versions >> $GITHUB_ENV
67-
- name: Build NodeJS Image
67+
- name: Build NodeJS image
6868
uses: ./.github/actions/ortdocker
6969
with:
7070
name: nodejs
@@ -77,7 +77,7 @@ jobs:
7777
YARN_VERSION=${{ env.YARN_VERSION }}
7878
7979
python_image:
80-
name: Python Image
80+
name: Python image
8181
needs: [base_image]
8282
runs-on: ubuntu-22.04
8383
steps:
@@ -86,7 +86,7 @@ jobs:
8686
- name: Set environment variables
8787
run: |
8888
cat .versions >> $GITHUB_ENV
89-
- name: Build Python Image
89+
- name: Build Python image
9090
uses: ./.github/actions/ortdocker
9191
with:
9292
name: python
@@ -103,7 +103,7 @@ jobs:
103103
SCANCODE_VERSION=${{ env.SCANCODE_VERSION }}
104104
105105
rust_image:
106-
name: Rust Image
106+
name: Rust image
107107
needs: [base_image]
108108
runs-on: ubuntu-22.04
109109
steps:
@@ -112,7 +112,7 @@ jobs:
112112
- name: Set environment variables
113113
run: |
114114
cat .versions >> $GITHUB_ENV
115-
- name: Build Rust Image
115+
- name: Build Rust image
116116
uses: ./.github/actions/ortdocker
117117
with:
118118
name: rust
@@ -122,7 +122,7 @@ jobs:
122122
RUST_VERSION=${{ env.RUST_VERSION }}
123123
124124
ruby_image:
125-
name: Ruby Image
125+
name: Ruby image
126126
needs: [base_image]
127127
runs-on: ubuntu-22.04
128128
steps:
@@ -131,7 +131,7 @@ jobs:
131131
- name: Set environment variables
132132
run: |
133133
cat .versions >> $GITHUB_ENV
134-
- name: Build Ruby Image
134+
- name: Build Ruby image
135135
uses: ./.github/actions/ortdocker
136136
with:
137137
name: ruby
@@ -142,7 +142,7 @@ jobs:
142142
COCOAPODS_VERSION=${{ env.COCOAPODS_VERSION }}
143143
144144
golang_image:
145-
name: Golang Image
145+
name: Golang image
146146
needs: [base_image]
147147
runs-on: ubuntu-22.04
148148
steps:
@@ -151,7 +151,7 @@ jobs:
151151
- name: Set environment variables
152152
run: |
153153
cat .versions >> $GITHUB_ENV
154-
- name: Build Golang Image
154+
- name: Build Golang image
155155
uses: ./.github/actions/ortdocker
156156
with:
157157
name: golang
@@ -163,7 +163,7 @@ jobs:
163163
164164
runtime_image:
165165
needs: [base_image, nodejs_image, python_image, rust_image, ruby_image, golang_image]
166-
name: Build ORT runtime Image
166+
name: Build ORT runtime image
167167
runs-on: ubuntu-22.04
168168
permissions:
169169
contents: read
@@ -177,17 +177,17 @@ jobs:
177177
run: |
178178
cat .versions >> $GITHUB_ENV
179179
180-
- name: Set up Docker Buildx
180+
- name: Set up Docker build
181181
uses: docker/setup-buildx-action@v2
182182

183-
- name: Login to GitHub Container Registry
183+
- name: Login to GitHub container registry
184184
uses: docker/login-action@v2
185185
with:
186186
registry: ${{ env.REGISTRY }}
187187
username: ${{ github.actor }}
188188
password: ${{ secrets.GITHUB_TOKEN }}
189189

190-
- name: Extract components metadata (tags, labels) for Ort runtime image
190+
- name: Extract components metadata (tags, labels)
191191
id: meta-ort
192192
uses: docker/metadata-action@v4
193193
with:
@@ -196,7 +196,7 @@ jobs:
196196
tags: |
197197
type=raw,sha,enable=true,format=short
198198
199-
- name: Build ORT runtime container
199+
- name: Build ORT runtime image
200200
if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
201201
uses: docker/build-push-action@v4
202202
with:

0 commit comments

Comments
 (0)