fix: remove logging on connection closing

Maxime Peim · fujita · commit 72f5b4b267c8 · 2025-11-01T07:42:40.000+09:00
The FSM handling of a TCP connection is pretty messy, and we always
close multiple times the same TCP connection. Hence, there is always
an error returned at the end of the fsm loop.
diff --git a/pkg/server/fsm.go b/pkg/server/fsm.go
@@ -1997,10 +1997,7 @@ func (h *fsmHandler) loop(ctx context.Context, wg *sync.WaitGroup) {
 	default:
 	}
 	if fsm.conn != nil {
-		err := fsm.conn.Close()
-		if err != nil {
-			fsm.logger.Error("failed to close existing tcp connection", slog.String("State", oldState.String()))
-		}
+		fsm.conn.Close()
 	}
 	close(fsm.connCh)
 	cleanInfiniteChannel(fsm.outgoingCh)

Original file line number	Diff line number	Diff line change
`@@ -1997,10 +1997,7 @@ func (h fsmHandler) loop(ctx context.Context, wg sync.WaitGroup) {`
`1997`	`1997`	`default:`
`1998`	`1998`	`}`
`1999`	`1999`	`if fsm.conn != nil {`
`2000`		`- err := fsm.conn.Close()`
`2001`		`- if err != nil {`
`2002`		`- fsm.logger.Error("failed to close existing tcp connection", slog.String("State", oldState.String()))`
`2003`		`- }`
	`2000`	`+ fsm.conn.Close()`
`2004`	`2001`	`}`
`2005`	`2002`	`close(fsm.connCh)`
`2006`	`2003`	`cleanInfiniteChannel(fsm.outgoingCh)`