server: reject route without origin attribute via AddPath()

fujita · fujita · commit 05021a6e5f92 · 2018-05-31T21:31:20.000+09:00
We should do stricter validation. Probably, we should use packet/bgp/validate.go. close #1660 Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
diff --git a/server/server.go b/server/server.go
@@ -1520,6 +1520,12 @@ func (server *BgpServer) fixupApiPath(vrfId string, pathList []*table.Path) erro
 	}
 
 	for _, path := range pathList {
+		if !path.IsWithdraw {
+			if _, err := path.GetOrigin(); err != nil {
+				return err
+			}
+		}
+
 		if path.GetSource() == nil {
 			path.SetSource(pi)
 		}

Original file line number	Diff line number	Diff line change
`@@ -1520,6 +1520,12 @@ func (server BgpServer) fixupApiPath(vrfId string, pathList []table.Path) erro`
`1520`	`1520`	`}`
`1521`	`1521`
`1522`	`1522`	`for _, path := range pathList {`
	`1523`	`+ if !path.IsWithdraw {`
	`1524`	`+ if _, err := path.GetOrigin(); err != nil {`
	`1525`	`+ return err`
	`1526`	`+ }`
	`1527`	`+ }`
	`1528`	`+`
`1523`	`1529`	`if path.GetSource() == nil {`
`1524`	`1530`	`path.SetSource(pi)`
`1525`	`1531`	`}`