fix: handle immutable headers returned by native fetch in middleware

GitOrigin-RevId: 5b52f855d2a996eb1c568229de675f8b67f2cb2a

Author: ory-bot

packages/nextjs/src/middleware/middleware.test.ts

@@ -43,12 +43,15 @@ const createMockRequest = (
 }
 
 const mockFetch = (responseInit: Partial<Response>) => {
-  global.fetch = jest.fn().mockResolvedValue(
-    new Response(responseInit.body || "", {
-      headers: new Headers(responseInit.headers || {}),
-      status: responseInit.status || 200,
-    }),
-  )
+  const response = new Response(responseInit.body || "", {
+    headers: new Headers(responseInit.headers || {}),
+    status: responseInit.status || 200,
+  })
+  // simulate immutable headers like those returned by undici's fetch
+  Object.defineProperty(response.headers, "append", { value: null })
+  Object.defineProperty(response.headers, "set", { value: null })
+  Object.defineProperty(response.headers, "delete", { value: null })
+  global.fetch = jest.fn().mockResolvedValue(response)
 }
 
 const createOptions = (): OryMiddlewareOptions => ({

packages/nextjs/src/middleware/middleware.ts

@@ -84,7 +84,7 @@ export async function proxyRequest(
   upstreamRequestHeaders.set("Ory-No-Custom-Domain-Redirect", "true")
 
   // Fetch the upstream response
-  const upstreamResponse = await fetch(upstreamUrl.toString(), {
+  let upstreamResponse = await fetch(upstreamUrl.toString(), {
     method: request.method,
     headers: upstreamRequestHeaders,
     body:
@@ -93,6 +93,12 @@ export async function proxyRequest(
         : null,
     redirect: "manual",
   })
+  upstreamResponse = new Response(upstreamResponse.body, {
+    status: upstreamResponse.status,
+    statusText: upstreamResponse.statusText,
+    // response may have immutable headers
+    headers: new Headers(upstreamResponse.headers),
+  })
 
   // Delete headers that should not be forwarded
   defaultOmitHeaders.forEach((header) => {