Ignore silently if file is already gone in delete callback

Author: benoit74

src/zimscraperlib/filesystem.py

@@ -12,6 +12,8 @@
 
 import magic
 
+from zimscraperlib import logger
+
 # override some MIME-types found by libmagic to different ones
 MIME_OVERRIDES = {
     "image/svg": "image/svg+xml",
@@ -44,5 +46,7 @@ def get_content_mimetype(content: bytes | str) -> str:
 
 def delete_callback(fpath: str | pathlib.Path):
     """helper deleting passed filepath"""
-
-    os.unlink(fpath)
+    if not pathlib.Path(fpath).exists():
+        logger.warning(f"delete callback: file {fpath} is already gone")
+    else:
+        os.unlink(fpath)

tests/filesystem/test_filesystem.py

@@ -1,6 +1,8 @@
 #!/usr/bin/env python
 # vim: ai ts=4 sts=4 et sw=4 nu
 
+import pathlib
+
 import magic
 
 from zimscraperlib.filesystem import (
@@ -51,3 +53,5 @@ def test_delete_callback(tmp_path):
     delete_callback(fpath)
 
     assert not fpath.exists()
+
+    delete_callback(pathlib.Path("/foo.txt"))