refactor: use creator object can_finish primitive instead of manual unlink

Author: lumpy72006

src/devdocs2zim/generator.py

@@ -496,8 +496,8 @@ def generate_zim(
         )
 
         # Start creator early to detect problems early.
-        try:
-            with creator as started_creator:
+        with creator as started_creator:
+            try:
                 logger.info("  Fetching the index...")
                 index = self.devdocs_client.get_index(doc_metadata.slug)
                 logger.debug(f"  The index has {len(index.entries)} entries.")
@@ -513,12 +513,10 @@ def generate_zim(
                     db=db,
                     common_resources=common_resources,
                 )
-        except Exception:
-            logger.error(f" Deleting incomplete ZIM file: {zim_path}")
-            zim_path.unlink(missing_ok=True)
+            except Exception:
+                started_creator.can_finish = False
 
-            # bubble the exception to entrypoint and exit with code 1
-            raise
+                raise
 
         return zim_path