Skip to content

Commit eb1e55f

Browse files
committed
bp update
1 parent b118c81 commit eb1e55f

10 files changed

Lines changed: 33 additions & 20 deletions

File tree

OWNERS_ALIASES

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
aliases:
66
srep-functional-team-aurora:
77
- abyrne55
8+
- AlexSmithGH
89
- dakotalongRH
10+
- eth1030
911
- joshbranham
1012
- luis-falcon
1113
- reedcort
@@ -65,14 +67,12 @@ aliases:
6567
- feichashao
6668
- samanthajayasinghe
6769
- xiaoyu74
68-
- Dee-6777
6970
- Tessg22
7071
- smarthall
7172
srep-infra-cicd:
7273
- ritmun
7374
- yiqinzhang
7475
- varunraokadaparthi
75-
- christophermancini
7676
srep-functional-leads:
7777
- abyrne55
7878
- clcollins
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
d7285a904eda6cf842ddff8c648dedb223934a75
1+
d77f951de81edbd4b87c1a27e79771b47ec6fdb2

boilerplate/_lib/container-make

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ if [[ "$1" == "-h"* ]] || [[ "$1" == "--h"* ]]; then
44
echo "Usage: $0 {arguments to the real 'make'}"
55
echo "Runs 'make' in the boilerplate backing container."
66
echo "If the command fails, starts a shell in the container so you can debug."
7+
echo "Set NONINTERACTIVE=true (or TRUE) to skip the debug shell and exit with the make return code."
78
exit -1
89
fi
910

@@ -40,12 +41,20 @@ banner "Running: make $@"
4041
$CONTAINER_ENGINE $args make "$@"
4142
rc=$?
4243

43-
# If it failed, drop into the container in a shell
44+
# If it failed, check if we should drop into a shell or exit
4445
if [[ $rc -ne 0 ]]; then
45-
banner "The 'make' command failed! Starting a shell in the container for debugging. Just 'exit' when done."
46-
$CONTAINER_ENGINE $args /bin/bash
46+
# Case-insensitive check for NONINTERACTIVE (true, TRUE, True all work)
47+
if [[ "${NONINTERACTIVE,,}" == "true" ]]; then
48+
banner "The 'make' command failed with exit code $rc. Skipping debug shell (NONINTERACTIVE=${NONINTERACTIVE})."
49+
else
50+
banner "The 'make' command failed! Starting a shell in the container for debugging. Just 'exit' when done."
51+
$CONTAINER_ENGINE $args /bin/bash
52+
fi
4753
fi
4854

4955
# Finally, remove the container
5056
banner "Cleaning up the container"
5157
$CONTAINER_ENGINE rm -f $container_id >/dev/null
58+
59+
# Exit with the return code from make
60+
exit $rc

boilerplate/openshift/golang-osd-e2e/update

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ OPERATOR_NAME_CAMEL_CASE=${OPERATOR_PROPER_NAME// /}
2121

2222
mkdir -p "${E2E_SUITE_DIRECTORY}"
2323

24-
E2E_SUITE_BUILDER_IMAGE=registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.24-openshift-4.20
24+
E2E_SUITE_BUILDER_IMAGE=registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.24-openshift-4.21
2525
if [[ -n ${KONFLUX_BUILDS} ]]; then
2626
E2E_SUITE_BUILDER_IMAGE="brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_1.24"
2727
fi

boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
aliases:
66
srep-functional-team-aurora:
77
- abyrne55
8+
- AlexSmithGH
89
- dakotalongRH
10+
- eth1030
911
- joshbranham
1012
- luis-falcon
1113
- reedcort
@@ -65,7 +67,6 @@ aliases:
6567
- feichashao
6668
- samanthajayasinghe
6769
- xiaoyu74
68-
- Dee-6777
6970
- Tessg22
7071
- smarthall
7172
srep-infra-cicd:

boilerplate/openshift/golang-osd-operator/standard.mk

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,7 @@ endif
364364
# Boilerplate container-make targets.
365365
# Runs 'make' in the boilerplate backing container.
366366
# If the command fails, starts a shell in the container so you can debug.
367+
# Set NONINTERACTIVE=true to skip the debug shell for CI/automation.
367368
.PHONY: container-test
368369
container-test:
369370
${BOILERPLATE_CONTAINER_MAKE} test
@@ -384,6 +385,11 @@ container-validate:
384385
container-coverage:
385386
${BOILERPLATE_CONTAINER_MAKE} coverage
386387

388+
# Run all container-* validation targets in sequence.
389+
# Set NONINTERACTIVE=true to skip debug shells and fail fast for CI/automation.
390+
.PHONY: container-all
391+
container-all: container-lint container-generate container-coverage container-test container-validate
392+
387393
.PHONY: rvmo-bundle
388394
rvmo-bundle:
389395
RELEASE_BRANCH=$(RELEASE_BRANCH) \

build/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ COPY . /osd-example-operator
66
WORKDIR /osd-example-operator
77
RUN make go-build
88

9-
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.6-1758184547
9+
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1763362218
1010
ENV OPERATOR=/usr/local/bin/osd-example-operator \
1111
USER_UID=1001 \
1212
USER_NAME=osd-example-operator

build/Dockerfile.olm-registry

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ COPY ${SAAS_OPERATOR_DIR} manifests
44
RUN initializer --permissive
55

66
# ubi-micro does not work for clusters with fips enabled unless we make OpenSSL available
7-
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.6-1758184547
7+
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1763362218
88

99
COPY --from=builder /bin/registry-server /bin/registry-server
1010
COPY --from=builder /bin/grpc_health_probe /bin/grpc_health_probe

test/e2e/osd_example_operator_runner_test.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
package osde2etests
55

66
import (
7-
"fmt"
87
"os"
98
"path/filepath"
109
"testing"
@@ -27,11 +26,3 @@ func TestOsdExampleOperator(t *testing.T) {
2726
}
2827
RunSpecs(t, "Osd Example Operator", suiteConfig, reporterConfig)
2928
}
30-
31-
// Failing test case added on purpose
32-
var _ = Describe("Intentional Failure Test", func() {
33-
It("should fail on purpose", func() {
34-
fmt.Println("Running Intentional Failure Test")
35-
Expect(true).To(BeFalse(), "This test is designed to fail intentionally")
36-
})
37-
})

test/e2e/osd_example_operator_tests.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ package osde2etests
55

66
import (
77
"context"
8-
8+
"fmt"
99
. "github.com/onsi/ginkgo/v2"
1010
. "github.com/onsi/gomega"
1111
)
@@ -14,4 +14,10 @@ var _ = Describe("osd-example-operator", func() {
1414
It("asserts success", func(ctx context.Context) {
1515
Expect(true).To(BeTrue(), "True should be true")
1616
})
17+
18+
// Failing test for log analysis demo
19+
It("should fail on purpose", func() {
20+
fmt.Println("Running Intentional Failure Test")
21+
Expect(true).To(BeFalse(), "This test is designed to fail intentionally")
22+
})
1723
})

0 commit comments

Comments
 (0)