Skip to content

chore: update spec dependencies#4229

Merged
tothandras merged 1 commit into
mainfrom
chore/update-spec-dependencies
Apr 28, 2026
Merged

chore: update spec dependencies#4229
tothandras merged 1 commit into
mainfrom
chore/update-spec-dependencies

Conversation

@tothandras
Copy link
Copy Markdown
Contributor

@tothandras tothandras commented Apr 24, 2026

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated build tooling and dependency versions to latest stable releases
    • Reorganized build scripts for improved workflow consistency and maintainability
  • Refactor

    • Refined credit grant tax configuration model structure

@tothandras tothandras requested a review from a team as a code owner April 24, 2026 20:07
@tothandras tothandras added the release-note/misc Miscellaneous changes label Apr 24, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

📝 Walkthrough

Walkthrough

This PR updates the TypeSpec generation build pipeline by renaming build scripts from compile to generate across multiple package configurations, bumps TypeSpec and related tooling dependencies to newer versions, streamlines devDependencies, and removes visibility annotations from optional fields in the credit grant specification.

Changes

Cohort / File(s) Summary
Build Configuration & Dependencies
api/spec/package.json, api/spec/packages/aip/package.json, api/spec/packages/legacy/package.json
Script entries renamed from compile to generate across all packages. TypeSpec compiler and related packages (http, openapi, rest, versioning) bumped to newer versions. Streamlined devDependencies in root package by removing broad tooling set. Prettier dependency removed from individual packages. Package manager version pinned and pnpm overrides updated (ajv/protobufjs removed, postcss constraint added).
TypeSpec Specification
api/spec/packages/aip/src/customers/credits/grant.tsp
Removed @visibility(Lifecycle.Read, Lifecycle.Create) annotations from behavior and tax_code optional fields in the CreditGrantTaxConfig model, making them implicitly visible without explicit lifecycle constraints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • turip
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main objective of the PR—updating spec dependencies across multiple package.json files and related TypeSpec configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-spec-dependencies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
api/spec/package.json (1)

34-36: The postcss override is actually needed — it's in the dep graph (showing up via a transitive dependency). The constraint syntax looks correct for pnpm, so it should resolve fine. Just a suggestion: add a quick comment explaining which transitive dep brings in postcss so it's clear why this override sticks around during future upgrades.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@api/spec/package.json` around lines 34 - 36, The overrides entry
"postcss@<8.5.10": ">=8.5.10" in package.json is required because a transitive
dependency pulls in an older postcss; run pnpm why postcss (or pnpm ls postcss)
to identify the specific transitive package (name and version) and then add a
short inline comment above the overrides key explaining which transitive
dependency is causing this override and why (e.g., "keeps postcss >=8.5.10
because X@vY requires postcss <8.5.10"); keep the override as-is and only add
the explanatory comment near the overrides entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@api/spec/package.json`:
- Around line 34-36: The overrides entry "postcss@<8.5.10": ">=8.5.10" in
package.json is required because a transitive dependency pulls in an older
postcss; run pnpm why postcss (or pnpm ls postcss) to identify the specific
transitive package (name and version) and then add a short inline comment above
the overrides key explaining which transitive dependency is causing this
override and why (e.g., "keeps postcss >=8.5.10 because X@vY requires postcss
<8.5.10"); keep the override as-is and only add the explanatory comment near the
overrides entry.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ee9b6f01-ce93-4c28-9698-48e5df086286

📥 Commits

Reviewing files that changed from the base of the PR and between 710826a and 856d225.

⛔ Files ignored due to path filters (19)
  • api/client/python/openmeter/__init__.py is excluded by !api/client/**
  • api/client/python/openmeter/_generated/_patch.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/_types.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/_utils/model_base.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/aio/_patch.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/aio/operations/_operations.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/aio/operations/_patch.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/models/__init__.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/models/_models.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/models/_patch.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/operations/_operations.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_generated/operations/_patch.py is excluded by !**/_generated/**, !api/client/**
  • api/client/python/openmeter/_types.py is excluded by !api/client/**
  • api/spec/patches/@typespec__compiler.patch is excluded by !api/spec/patches/**
  • api/spec/patches/@typespec__http-client-python.patch is excluded by !api/spec/patches/**
  • api/spec/patches/@typespec__http.patch is excluded by !api/spec/patches/**
  • api/spec/patches/@typespec__openapi.patch is excluded by !api/spec/patches/**
  • api/spec/patches/@typespec__openapi3.patch is excluded by !api/spec/patches/**
  • api/spec/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • api/spec/package.json
  • api/spec/packages/aip/package.json
  • api/spec/packages/aip/src/customers/credits/grant.tsp
  • api/spec/packages/legacy/package.json
💤 Files with no reviewable changes (1)
  • api/spec/packages/aip/src/customers/credits/grant.tsp

@tothandras tothandras enabled auto-merge (squash) April 28, 2026 13:28
@tothandras tothandras merged commit 57b578c into main Apr 28, 2026
30 of 32 checks passed
@tothandras tothandras deleted the chore/update-spec-dependencies branch April 28, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/misc Miscellaneous changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants