Replace closed MCP connections during reconciliation - #34957
Merged
copyberry[bot] merged 1 commit intoJul 23, 2026
Merged
Conversation
## Why MCP connection reconciliation can otherwise reuse a client after its service or underlying transport has stopped. ## What changed - Add `RmcpClient::is_closed` to report closed client, service, and transport states. - Exclude closed clients when selecting a reusable MCP connection so reconciliation starts a replacement. ## Testing - Add a reconciliation test that disconnects an in-process MCP transport and verifies that its connection is replaced. GitOrigin-RevId: 366a85c9959dbe1763923d7e33a4ecf52d9c3c6a
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/366a85c9959dbe1763923d7e33a4ecf52d9c3c6a
branch
from
July 23, 2026 15:29
db5e4b6 to
34b935e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/366a85c9959dbe1763923d7e33a4ecf52d9c3c6a
branch
July 23, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace closed MCP connections during reconciliation
Why
MCP connection reconciliation can otherwise reuse a client after its service or
underlying transport has stopped.
What changed
RmcpClient::is_closedto report closed client, service, and transportstates.
reconciliation starts a replacement.
Testing
verifies that its connection is replaced.