-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update postgresqlreceiver vacuum metric unit to vacuum not vacuums #43272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update postgresqlreceiver vacuum metric unit to vacuum not vacuums #43272
Conversation
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
e91b0e6 to
b11429b
Compare
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
b11429b to
80865cd
Compare
|
Please add a changelog item in |
|
@dmitryax Absolutely! Thanks. |
80865cd to
82982fa
Compare
|
@dmitryax Would this be considered a breaking change? I made it non-breaking because the unit is actually the same with the same semantics except for the name now is using the singular form. WDYT? |
1abfb36 to
d2e85da
Compare
|
Thank you for your contribution @beshbeeshy! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
Updating the unit of the metric
postgresql.table.vacuum.countinpostgresqlreceiverto bevacuuminstead ofvacuums, to comply with the semantic conventions.Link to tracking issue
Fixes: #43207
Testing
Documentation