Skip to content

Conversation

@beshbeeshy
Copy link
Contributor

@beshbeeshy beshbeeshy commented Oct 8, 2025

Updating the unit of the metric postgresql.table.vacuum.count in postgresqlreceiver to be vacuum instead of vacuums, to comply with the semantic conventions.

Link to tracking issue

Fixes: #43207

Testing

Documentation

@beshbeeshy beshbeeshy requested a review from a team as a code owner October 8, 2025 14:59
@beshbeeshy beshbeeshy requested a review from dmitryax October 8, 2025 14:59
@github-actions github-actions bot added the first-time contributor PRs made by new contributors label Oct 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@beshbeeshy beshbeeshy force-pushed the postgresqlreceiver-vacuum-count-metric-unit branch 4 times, most recently from e91b0e6 to b11429b Compare October 10, 2025 17:51
@github-actions
Copy link
Contributor

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@beshbeeshy beshbeeshy force-pushed the postgresqlreceiver-vacuum-count-metric-unit branch from b11429b to 80865cd Compare October 11, 2025 12:12
@dmitryax
Copy link
Member

Please add a changelog item in .chlogen

@beshbeeshy
Copy link
Contributor Author

@dmitryax Absolutely! Thanks.

@beshbeeshy beshbeeshy force-pushed the postgresqlreceiver-vacuum-count-metric-unit branch from 80865cd to 82982fa Compare October 17, 2025 22:31
@beshbeeshy
Copy link
Contributor Author

@dmitryax Would this be considered a breaking change? I made it non-breaking because the unit is actually the same with the same semantics except for the name now is using the singular form.

WDYT?

@beshbeeshy beshbeeshy force-pushed the postgresqlreceiver-vacuum-count-metric-unit branch from 1abfb36 to d2e85da Compare October 22, 2025 09:21
@dmitryax dmitryax merged commit dc2f417 into open-telemetry:main Oct 22, 2025
189 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 22, 2025
@otelbot
Copy link
Contributor

otelbot bot commented Oct 22, 2025

Thank you for your contribution @beshbeeshy! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

@beshbeeshy beshbeeshy deleted the postgresqlreceiver-vacuum-count-metric-unit branch October 22, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[receiver/postgresql] Fix unit for postgresql.table.vacuum.count metric

4 participants