Skip to content

[receiver/libhoney] Response body sends proper partial errors for batches #42272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TylerHelmuth merged 12 commits into from
Sep 25, 2025
Merged

[receiver/libhoney] Response body sends proper partial errors for batches #42272

TylerHelmuth merged 12 commits into from
Sep 25, 2025

Conversation

@mterhar
Copy link
Member

@mterhar mterhar commented Aug 26, 2025 •
edited
Loading

Description

  • Responds to libhoney clients with array of success and failures statuses for proper error handling
  • Sets both JSON and Webpack timestamps to avoid nil

Testing

Adds unit tests for timestamps and response body generation

@mterhar mterhar changed the title [receivers/libhoney] Avoid panics with specific configurations [receiver/libhoney] Avoid panics with specific configurations Aug 26, 2025
@mterhar mterhar marked this pull request as ready for review August 27, 2025 15:42
@mterhar mterhar requested review from a team and TylerHelmuth as code owners August 27, 2025 15:42
TylerHelmuth
TylerHelmuth reviewed Aug 27, 2025
View reviewed changes
@mterhar mterhar changed the title [receiver/libhoney] Avoid panics with specific configurations [receiver/libhoney] Handle scopes and return proper errors Aug 29, 2025
@mterhar mterhar force-pushed the libhoney/single-http-response branch from b8f19af to 85c1b79 Compare August 29, 2025 14:18
@mterhar mterhar marked this pull request as draft September 2, 2025 16:34
@mterhar mterhar force-pushed the libhoney/single-http-response branch 2 times, most recently from 9339f03 to 4f6c4aa Compare September 4, 2025 18:08
@mterhar mterhar marked this pull request as ready for review September 4, 2025 18:15
@mterhar mterhar changed the title [receiver/libhoney] Handle scopes and return proper errors [receiver/libhoney] Response body sends proper partial errors for batches Sep 4, 2025
TylerHelmuth
TylerHelmuth reviewed Sep 8, 2025
View reviewed changes
@mterhar mterhar force-pushed the libhoney/single-http-response branch from 9af3c11 to ee23c92 Compare September 9, 2025 14:48
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 24, 2025
@mterhar mterhar force-pushed the libhoney/single-http-response branch from 0a6d574 to f06193b Compare September 24, 2025 18:29
@github-actions github-actions bot removed the Stale label Sep 25, 2025
@TylerHelmuth TylerHelmuth merged commit 442d8b8 into open-telemetry:main Sep 25, 2025
186 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees

@fatsheep9146 fatsheep9146

@MovieStoreGuy MovieStoreGuy

Labels

receiver/libhoney

Projects

None yet

Milestone

v0.137.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mterhar @TylerHelmuth @fatsheep9146 @MovieStoreGuy