-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[receiver/awscloudwatch] Added pattern filter option for log groups #40981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7b91038 to
324d572
Compare
schmikei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great add to me as a codeowner, will wait to see if CI succeeds
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@open-telemetry/collector-contrib-approvers if anybody has a spare second to enable workflows for this PR and merge if it looks good to them as well? As a codeowner I think this PR looks good to me |
Co-authored-by: Sam DeHaan <[email protected]>
Co-authored-by: Sam DeHaan <[email protected]>
Co-authored-by: Sam DeHaan <[email protected]>
Co-authored-by: Sam DeHaan <[email protected]>
Description
Adds the additional config option
pattern, which allows a user to pass in a case-sensitive search string for log groups. This is an alternative toprefixand only one can be used.Testing
Added additional tests for both the log fetching functionality and configuration tests to verify only
prefixorpatterncan be used.