Skip to content

Conversation

@dyl10s
Copy link
Contributor

@dyl10s dyl10s commented Jun 29, 2025

Description

Adds the additional config option pattern, which allows a user to pass in a case-sensitive search string for log groups. This is an alternative to prefix and only one can be used.

Testing

Added additional tests for both the log fetching functionality and configuration tests to verify only prefix or pattern can be used.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 29, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@dyl10s dyl10s force-pushed the cloudwatch-add-pattern branch from 7b91038 to 324d572 Compare June 29, 2025 22:59
@dyl10s dyl10s marked this pull request as ready for review June 29, 2025 23:03
@dyl10s dyl10s requested a review from a team as a code owner June 29, 2025 23:03
@dyl10s dyl10s requested a review from crobert-1 June 29, 2025 23:03
Copy link
Contributor

@schmikei schmikei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great add to me as a codeowner, will wait to see if CI succeeds

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 15, 2025
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 31, 2025
@github-actions github-actions bot removed the Stale label Aug 1, 2025
@schmikei
Copy link
Contributor

schmikei commented Aug 7, 2025

@open-telemetry/collector-contrib-approvers if anybody has a spare second to enable workflows for this PR and merge if it looks good to them as well? As a codeowner I think this PR looks good to me

@dyl10s dyl10s requested a review from dehaansa August 9, 2025 20:16
@dehaansa dehaansa added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels Aug 11, 2025
@edmocosta edmocosta merged commit c7291f2 into open-telemetry:main Aug 11, 2025
207 of 208 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Code review completed; ready to merge by maintainers receiver/awscloudwatch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants