Skip to content

Conversation

@lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 21, 2025

  • Warn about CSP blocking import map
  • In dev mode since Update parcel #2174 parcel showed annoying error overlays
  • @parcel/error-overlay doesn't need special CSP anymore

@lukaw3d lukaw3d requested a review from buberdds May 21, 2025 23:13
@github-actions
Copy link

github-actions bot commented May 21, 2025

Deployed to Cloudflare Pages

Latest commit: cfb575767e4aa2329b9863645582c56eeb07aefc
Status:✅ Deploy successful!
Preview URL: https://482bd03c.oasis-wallet.pages.dev
Alias: https://pr-2181.oasis-wallet.pages.dev

@socket-security
Copy link

socket-security bot commented May 21, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​emotion/​memoize@​0.8.0 ⏵ 0.9.01001005882100
Updated@​emotion/​is-prop-valid@​1.2.0 ⏵ 1.3.1100 +11007283100
Updateddeepmerge@​4.2.2 ⏵ 4.3.1100 +110010076100
Updatedgrommet-icons@​4.12.0 ⏵ 4.12.495 +110010083100
Updatedgrommet@​2.36.1 ⏵ 2.47.092 +110010094 -1100

View full report

@lukaw3d lukaw3d force-pushed the lw/fix-parcel-upgrade-warnings branch from 7ee199f to c6ad11f Compare May 22, 2025 00:37
Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: create follow up QA task in sprint to test everything once parcel fixes are merged

'unsafe-eval'
`

const warnImportMapViolation = async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview
Screenshot from 2025-05-21 01-04-06

@lukaw3d lukaw3d force-pushed the lw/fix-parcel-upgrade-warnings branch from c6ad11f to cfb5757 Compare May 22, 2025 20:51
@lukaw3d lukaw3d merged commit 3f5734c into master May 22, 2025
21 checks passed
@lukaw3d lukaw3d deleted the lw/fix-parcel-upgrade-warnings branch May 22, 2025 21:22
@lukaw3d lukaw3d mentioned this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants