From cb7df9a11eedd10fa159228bc3493a203a37d4be Mon Sep 17 00:00:00 2001 From: Keran Yang Date: Sat, 3 May 2025 11:45:42 -0400 Subject: [PATCH 1/2] fix: remove private constructor for sideinput Constant as Constants.SIDE_INPUT_DIR is exposed to user Signed-off-by: Keran Yang --- src/main/java/io/numaproj/numaflow/sideinput/Constants.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/main/java/io/numaproj/numaflow/sideinput/Constants.java b/src/main/java/io/numaproj/numaflow/sideinput/Constants.java index 27863e83..8683e5dc 100644 --- a/src/main/java/io/numaproj/numaflow/sideinput/Constants.java +++ b/src/main/java/io/numaproj/numaflow/sideinput/Constants.java @@ -7,9 +7,4 @@ class Constants { static final String DEFAULT_HOST = "localhost"; static int DEFAULT_MESSAGE_SIZE = 1024 * 1024 * 64; static int DEFAULT_PORT = 50051; - - // Private constructor to prevent instantiation - private Constants() { - throw new IllegalStateException("Utility class 'Constants' should not be instantiated"); - } } From 2ade1603db22ecfd9cb0567409a97276699ad13e Mon Sep 17 00:00:00 2001 From: Keran Yang Date: Sat, 3 May 2025 13:00:45 -0400 Subject: [PATCH 2/2] . Signed-off-by: Keran Yang --- .../java/io/numaproj/numaflow/sideinput/Constants.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/main/java/io/numaproj/numaflow/sideinput/Constants.java b/src/main/java/io/numaproj/numaflow/sideinput/Constants.java index 8683e5dc..91a7f2bd 100644 --- a/src/main/java/io/numaproj/numaflow/sideinput/Constants.java +++ b/src/main/java/io/numaproj/numaflow/sideinput/Constants.java @@ -1,10 +1,15 @@ package io.numaproj.numaflow.sideinput; -class Constants { +public class Constants { public static final String SIDE_INPUT_DIR = "/var/numaflow/side-inputs"; static final String DEFAULT_SOCKET_PATH = "/var/run/numaflow/sideinput.sock"; static final String DEFAULT_SERVER_INFO_FILE_PATH = "/var/run/numaflow/sideinput-server-info"; static final String DEFAULT_HOST = "localhost"; static int DEFAULT_MESSAGE_SIZE = 1024 * 1024 * 64; static int DEFAULT_PORT = 50051; + + // Private constructor to prevent instantiation + private Constants() { + throw new IllegalStateException("Utility class 'Constants' should not be instantiated"); + } }