Skip to content

Commit ac3166d

Browse files
authored
chore: remove unused code (#125)
Signed-off-by: a3hadi <a3hadi@protonmail.com>
1 parent ca8b5e7 commit ac3166d

File tree

3 files changed

+3
-11
lines changed

3 files changed

+3
-11
lines changed

.github/workflows/build-push.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ on:
88

99
jobs:
1010
docker_publish:
11-
# run it only on numaproj/numaflow-java repository
12-
# forked repositories normally don't have the proper permission setup.
11+
# run workflow only on numaproj/numaflow-java repository
1312
if: ${{ github.repository }} == "numaproj/numaflow-java"
1413
name: Build, Tag, and Push Image
1514
runs-on: ubuntu-latest

development.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,4 @@ If you add a new example, there are a few steps to follow in order for it to be
4747

4848
1. Add the example to the `examples/pom.xml`, within an execution element. Note that the
4949
`id` tag you specify must be exactly the same as the quay.io repository name for the example
50-
2. Add the `id` tag you specified in step 1 to the `executionIDs` array in `hack/update_examples.sh`
51-
3. Add the `id` tag you specified in step 1 to the `execution_ids` matrix in `.github/workflows/build-push.yaml`
50+
2. Add the `id` tag you specified in step 1 to the `execution_ids` matrix in `.github/workflows/build-push.yaml`

hack/update_examples.sh

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ function show_help () {
44
echo "Usage: $0 [-h|--help | -t|--tag <tag>] (-bpe|--build-push-example <execution-id>)"
55
echo " -h, --help Display help message and exit"
66
echo " -bpe, --build-push-example Build the given example id (found in examples/pom.xml), and push it to the quay.io registry"
7-
echo " -t, --tag To be optionally used with -bpe or -bp. Specify the tag to build with. Default tag: stable"
7+
echo " -t, --tag To be optionally used with -bpe. Specify the tag to build with. Default tag: stable"
88
}
99

1010
if [ $# -eq 0 ]; then
@@ -79,12 +79,6 @@ if [ -n "$tag" ] && (( ! usingHelp )); then
7979
echo "Using tag: $tag"
8080
fi
8181

82-
executionIDs=("mapt-event-time-filter-function" "flat-map-stream" "map-flatmap" \
83-
"even-odd" "simple-sink" "reduce-sum" "reduce-stream-sum" \
84-
"map-forward-message" "reduce-counter" "sideinput-example" \
85-
"udf-sideinput-example" "source-simple-source" "session-reduce-count"
86-
)
87-
8882
function dockerPublish () {
8983
echo "Docker publish for example: $1"
9084
if ! docker tag numaflow-java-examples/"$1":"$tag" quay.io/numaio/numaflow-java/"$1":"$tag"; then

0 commit comments

Comments
 (0)