This repository was archived by the owner on Sep 28, 2025. It is now read-only.
Conversation
Collaborator
Author
I realize the best way to solve this, actually involves enough work to be a feature of its own (or at least depend on new traits in |
Collaborator
Author
This too stems from the larger issue of inefficiently performing redundant computations in several iterators. Addressing this will be much easier (and less future work) once #19 is resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #18, but leaves some room for improvement w.r.t. prover efficiency. Currently the prover tediously computes the
mu_lexponent for each indexlin his proof. This could be optimized in future work to use a more efficient exponentiation algorithm (e.g. square and add), compute eachmu_lin a single iterative computation, or both.TODO:
mu_kexponentially (e.g.mu^k) instead of via keyed hash (e.g.blake2b(mu, k))mu^kcoefficientsAdd macro or utility function to more efficiently computemu^lfor each of the prover's inputsIn verifier, combinefactors_Uandfactors_M_kcomputation to share iteration overmu_k, instead of each iterating independentlyIncidentally, this PR also resolves #23