.addError() not called on SkipTest, etc.

[jpellerin]

What steps will reproduce the problem?

1. Write a plugin, P, that uses .addError
2. Raise SkipTest in a test

What is the expected output? What do you see instead?

Expected: .addError() is called on P
Got: .addError() is not called on P (assuming
nose.plugins.skip.Skip.addError is called before P.addError by the plugin
manager)

See attached patch for a proper test.

Please use labels and text to provide additional information.

As well as having .addError called, we also still need an interface for
plugins to find out whether an error is ignored. For example, plugin debug
needs this, so that it doesn't try to drop into the debugger on errors that
won't cause an unsuccessful test run, like skips. ATM, this is done by
returning False, which is what stops other plugins' .addError() methods
from getting called.

Discussion:
http://groups.google.com/group/nose-dev/browse_thread/thread/b1d726998dc79bd9

Google Code Info:
Issue #: 169
Author: j...@pobox.com
Created On: 2008-03-10T23:47:10.000Z
Closed On:

[jpellerin]

Google Code Info:
Author: j...@pobox.com
Created On: 2008-03-10T23:47:47.000Z

[jpellerin]

I also get the same issue: I am using nosetests v0.10.4

Did anyone understand what is going on?

Thanks,
Vincent

Google Code Info:
Author: vincent....@gmail.com
Created On: 2009-08-13T14:13:07.000Z

[jpellerin]

Still doesn't work. Using nose 0.11.3 and Python 2.7 on Fedora 14.

Below is a patch that calls addSkip() in the plugin. I realize the manual says it's deprecated, but it works for me.

--- result.py.orig 2010-12-20 11:54:06.904684002 +0100
+++ result.py 2010-12-20 11:33:30.596684002 +0100
@@ -50,6 +50,7 @@
storage, label, isfail = self.errorClasses[SkipTest]
storage.append((test, reason))
self.printLabel(label, (SkipTest, reason, None))

•    self.config.plugins.addSkip(test)
  

  def addError(self, test, err):
  """Overrides normal addError to add support for

Google Code Info:
Author: geertj@gmail.com
Created On: 2010-12-20T10:55:33.000Z

[jpellerin]

I still have this problem on nose 1.1.2. Neither addSkip nor addError is called to handle a Skip. Same goes for DeprecatedTest.

Google Code Info:
Author: pettazz
Created On: 2011-11-23T00:43:26.000Z

[Bentis]

Still a problem in nose 1.2.0, however I quickfixed this by giving my plugin a score above that of the Skip/Deprecated/Custom error class plugins (default score of 1000). That way my plugin gets the addError call before the error class which suppresses it.

[wiggin15]

this was broken since 773dc1c - looks like it was intentional to prevent --pdb from triggering on Skip errors. The problematic code is now in errorclass.py - since its score is high and it returns True in addError it prevents any other plugins from getting addError in case of Skip\Deprecated.
It shouldn't do that, the fix would be to remove the addError handler in errorclass.py and prevent --pdb from triggering by checking for Skip\Deprecated in the pdb plugin itself. It will be a bit ugly to check for the specific exceptions in Pdb.addError, but unfortunately that's what all plugins that are sensitive to Skip have to do, now that addSkip and addDeprecated are deprecated. That's what the plugin documentation suggests (IMHO addSkip shouldn't be deprecated, and SkipTest shouldn't cause an addError call, but looks like that decision has been made).

[SebaM]

Why this patch wasn't marged w/ master? About one year later it could be still problem. Eg. in my case I need upload test data to db so I'm using nosedbreport plugin. The problem I'm encountered was not working plugin in case of skip test. After applying this patch works much better.

[davydany]

I'm with @SebaM, can this be merged with master?