Skip to content

Commit 78b41da

Browse files
committed
buffer: fix isEncoding result for empty string
1 parent 94a120c commit 78b41da

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

lib/buffer.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,7 @@ Buffer.compare = function compare(a, b) {
375375

376376
Buffer.isEncoding = function(encoding) {
377377
return typeof encoding === 'string' &&
378+
encoding.length > 0 &&
378379
typeof internalUtil.normalizeEncoding(encoding) === 'string';
379380
};
380381
Buffer[internalUtil.kIsEncodingSymbol] = Buffer.isEncoding;

test/parallel/test-buffer-isencoding.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,13 @@ const assert = require('assert');
1717
assert.strictEqual(Buffer.isEncoding(enc), true);
1818
});
1919

20-
[ 'utf9',
20+
[ '',
21+
'utf9',
2122
'utf-7',
2223
'Unicode-FTW',
2324
'new gnu gun',
25+
undefined,
26+
null,
2427
false,
2528
NaN,
2629
{},

0 commit comments

Comments
 (0)