feat(win): allow VCINSTALLDIR to specify a portable instance#3036
Merged
legendecas merged 1 commit intonodejs:mainfrom Jul 9, 2024
Merged
feat(win): allow VCINSTALLDIR to specify a portable instance#3036legendecas merged 1 commit intonodejs:mainfrom
legendecas merged 1 commit intonodejs:mainfrom
Conversation
Contributor
StefanStojanovic
left a comment
There was a problem hiding this comment.
This looks reasonable. A few things are assumed, so they are a weak spot, but I guess there is not much we can do about it?
Member
Author
|
@StefanStojanovic thanks for the review. While trusting what the VS developer command prompt sets in the environment variables, the |
StefanStojanovic
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesdocumentation is changed or addedDescription of change
When node-gyp is running in a developer command prompt from a portable enterprise VS instance, allow node-gyp to use the specified instance instead of reporting that the instance found from the VSInstaller doesn't match the environ
VCINSTALLDIR. Tools like CMake can use a portable VS instance as well: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/6651.