Merge pull request #5867 from nextcloud/backport/5863/stable27

juliusknorr · web-flow · commit 96cdd2d581e1 · 2024-06-07T10:31:39.000+02:00
[stable27] fix(locks): only lock when editing
diff --git a/lib/Service/ApiService.php b/lib/Service/ApiService.php
@@ -164,9 +164,11 @@ public function create(?int $fileId = null, ?string $filePath = null, ?string $b
 			$lockInfo = null;
 		}
 
-		$isLocked = $this->documentService->lock($file->getId());
-		if (!$isLocked) {
-			$readOnly = true;
+		if (!$readOnly) {
+			$isLocked = $this->documentService->lock($file->getId());
+			if (!$isLocked) {
+				$readOnly = true;
+			}
 		}
 
 		return new DataResponse([

Original file line number	Diff line number	Diff line change
`@@ -164,9 +164,11 @@ public function create(?int $fileId = null, ?string $filePath = null, ?string $b`
`164`	`164`	`$lockInfo = null;`
`165`	`165`	`}`
`166`	`166`
`167`		`- $isLocked = $this->documentService->lock($file->getId());`
`168`		`- if (!$isLocked) {`
`169`		`- $readOnly = true;`
	`167`	`+ if (!$readOnly) {`
	`168`	`+ $isLocked = $this->documentService->lock($file->getId());`
	`169`	`+ if (!$isLocked) {`
	`170`	`+ $readOnly = true;`
	`171`	`+ }`
`170`	`172`	`}`
`171`	`173`
`172`	`174`	`return new DataResponse([`