diff --git a/lib/private/DB/Adapter.php b/lib/private/DB/Adapter.php index edd8c1bf023e8..8f1b8e6d75f48 100644 --- a/lib/private/DB/Adapter.php +++ b/lib/private/DB/Adapter.php @@ -28,25 +28,11 @@ public function __construct($conn) { /** * @param string $table name * - * @return int id of last insert statement, 0 in case there was no INSERT before or it failed to get the ID + * @return int id of last insert statement * @throws Exception */ - public function lastInsertId($table, bool $allowRetry = true): int { - $return = $this->conn->realLastInsertId($table); - if ($return === 0 && $allowRetry) { - /** - * During a reconnect we are losing the connection and when the - * realLastInsertId call is the one triggering the reconnect, it - * does not return the ID. But inside the reconnect, we were able - * to save the last insert id, so calling it a second time is going - * to be successful. - * We can not return the result on the initial call, as we are already - * way deeper in the stack performing the actual database query on - * the doctrine driver. - */ - return $this->lastInsertId($table, false); - } - return $return; + public function lastInsertId($table) { + return (int)$this->conn->realLastInsertId($table); } /** diff --git a/lib/private/DB/AdapterOCI8.php b/lib/private/DB/AdapterOCI8.php index f5ad9f7c934ef..0a509090bcadc 100644 --- a/lib/private/DB/AdapterOCI8.php +++ b/lib/private/DB/AdapterOCI8.php @@ -8,7 +8,7 @@ namespace OC\DB; class AdapterOCI8 extends Adapter { - public function lastInsertId($table, bool $allowRetry = true): int { + public function lastInsertId($table) { if (is_null($table)) { throw new \InvalidArgumentException('Oracle requires a table name to be passed into lastInsertId()'); } diff --git a/lib/private/DB/AdapterPgSql.php b/lib/private/DB/AdapterPgSql.php index b321fcf47156c..db48c81c2c54c 100644 --- a/lib/private/DB/AdapterPgSql.php +++ b/lib/private/DB/AdapterPgSql.php @@ -9,7 +9,7 @@ class AdapterPgSql extends Adapter { - public function lastInsertId($table, bool $allowRetry = true): int { + public function lastInsertId($table) { $result = $this->conn->executeQuery('SELECT lastval()'); $val = $result->fetchOne(); $result->free(); diff --git a/lib/private/DB/Connection.php b/lib/private/DB/Connection.php index 4ba2d2a341d1b..96dd578b2eff4 100644 --- a/lib/private/DB/Connection.php +++ b/lib/private/DB/Connection.php @@ -92,8 +92,6 @@ class Connection extends PrimaryReadReplicaConnection { protected ShardConnectionManager $shardConnectionManager; protected AutoIncrementHandler $autoIncrementHandler; protected bool $isShardingEnabled; - protected bool $disableReconnect = false; - protected int $lastInsertId = 0; public const SHARD_PRESETS = [ 'filecache' => [ @@ -512,9 +510,9 @@ protected function logQueryToFile(string $sql, array $params): void { * because the underlying database may not even support the notion of AUTO_INCREMENT/IDENTITY * columns or sequences. * - * @param ?string $name Name of the sequence object from which the ID should be returned. + * @param string $seqName Name of the sequence object from which the ID should be returned. * - * @return int the last inserted ID, 0 in case there was no INSERT before or it failed to get the ID + * @return int the last inserted ID. * @throws Exception */ public function lastInsertId($name = null): int { @@ -528,13 +526,8 @@ public function lastInsertId($name = null): int { * @internal * @throws Exception */ - public function realLastInsertId($seqName = null): int { - if ($this->lastInsertId !== 0) { - $lastInsertId = $this->lastInsertId; - $this->lastInsertId = 0; - return $lastInsertId; - } - return (int)parent::lastInsertId($seqName); + public function realLastInsertId($seqName = null) { + return parent::lastInsertId($seqName); } /** @@ -903,23 +896,11 @@ private function reconnectIfNeeded(): void { if ( !isset($this->lastConnectionCheck[$this->getConnectionName()]) || time() <= $this->lastConnectionCheck[$this->getConnectionName()] + 30 || - $this->isTransactionActive() || - $this->disableReconnect + $this->isTransactionActive() ) { return; } - if ($this->getDatabaseProvider() === IDBConnection::PLATFORM_MYSQL) { - /** - * Before reconnecting we save the lastInsertId, so that if the reconnect - * happens between the INSERT executeStatement() and the getLastInsertId call - * we are able to return the correct result after all. - */ - $this->disableReconnect = true; - $this->lastInsertId = (int)parent::lastInsertId(); - $this->disableReconnect = false; - } - try { $this->_conn->query($this->getDriver()->getDatabasePlatform()->getDummySelectSQL()); $this->lastConnectionCheck[$this->getConnectionName()] = time(); diff --git a/tests/lib/Comments/ManagerTest.php b/tests/lib/Comments/ManagerTest.php index fb2f913f29117..86e70c56026a5 100644 --- a/tests/lib/Comments/ManagerTest.php +++ b/tests/lib/Comments/ManagerTest.php @@ -1073,6 +1073,7 @@ public static function providerTestReactionAddAndDelete(): array { * @return array */ private function proccessComments(array $data): array { + $this->connection->beginTransaction(); /** @var array $comments */ $comments = []; foreach ($data as $comment) { @@ -1088,6 +1089,7 @@ private function proccessComments(array $data): array { $comment = $this->testSave($message, $actorId, $verb, $parentId, $id); $comments[$comment->getMessage() . '#' . $comment->getActorId()] = $comment; } + $this->connection->commit(); return $comments; }