From 1ba1bd252dfb612ab45a8e4dad5108e6ee041a3f Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Fri, 9 Oct 2020 12:15:20 +0200 Subject: [PATCH 1/2] Add to README about compiling JS production assets. Add note in README about the need to checkin also compiled JS assets after running `make build-js-production`. Signed-off-by: Vincent Petry --- README.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index f74dea783c54d..5f306725cdf97 100644 --- a/README.md +++ b/README.md @@ -89,6 +89,13 @@ Then inside the root folder of your local Nextcloud development installation, ru ./build/compile-handlebars-templates.sh ``` +Before checking in JS changes, make sure to also build for production: +``` +make build-js-production +``` +Then add the compiled files for committing. + +Please note that if you used `make build-js` or `make watch-js` before almost all files changed, so might need to clear the workspace first. ### Tools we use 🛠 From 77a1a600044871a14a404cde82332c260c43eb22 Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Fri, 9 Oct 2020 14:12:40 +0200 Subject: [PATCH 2/2] Enhance README to mention module compilation Added hint about MODULE=xxx when recompiling production assets. Signed-off-by: Vincent Petry --- README.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 5f306725cdf97..dd7459b68a085 100644 --- a/README.md +++ b/README.md @@ -95,7 +95,12 @@ make build-js-production ``` Then add the compiled files for committing. -Please note that if you used `make build-js` or `make watch-js` before almost all files changed, so might need to clear the workspace first. +To save some time, to only rebuild for a specific app, use the following and replace the module with the app name: +``` +MODULE=user_status make build-js-production +``` + +Please note that if you used `make build-js` or `make watch-js` before, you'll notice that a lot of files were marked as changed, so might need to clear the workspace first. ### Tools we use ðŸ›