[stable12] Allow to close sidebar for text files#6525
Merged
MorrisJobke merged 1 commit intostable12from Sep 20, 2017
Merged
Conversation
* the close button was overlapped by the text preview and you could not close the sidebar then Signed-off-by: Morris Jobke <hey@morrisjobke.de>
skjnldsv
approved these changes
Sep 15, 2017
Codecov Report
@@ Coverage Diff @@
## stable12 #6525 +/- ##
==============================================
- Coverage 53.77% 53.77% -0.01%
Complexity 22527 22527
==============================================
Files 1383 1383
Lines 86498 86498
Branches 1328 1328
==============================================
- Hits 46517 46515 -2
- Misses 39981 39983 +2
|
Member
|
Works, however if the text in the first line is long, the X will overlay the text and is not discoverable anymore. |
nickvergessen
approved these changes
Sep 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #6499
Tested and works here 👍