Skip to content

Commit ffd0c9d

Browse files
committed
fix(files): also trigger new tab on file name middle click
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
1 parent a5fd623 commit ffd0c9d

4 files changed

Lines changed: 9 additions & 5 deletions

File tree

apps/files/src/components/FileEntry.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
<FileEntryPreview ref="preview"
3131
:source="source"
3232
:dragover="dragover"
33+
@auxclick.native="execDefaultAction"
3334
@click.native="execDefaultAction" />
3435

3536
<FileEntryName ref="name"
@@ -38,7 +39,8 @@
3839
:files-list-width="filesListWidth"
3940
:nodes="nodes"
4041
:source="source"
41-
@click="execDefaultAction" />
42+
@auxclick.native="execDefaultAction"
43+
@click.native="execDefaultAction" />
4244
</td>
4345

4446
<!-- Actions -->

apps/files/src/components/FileEntry/FileEntryName.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@
2626
:aria-hidden="isRenaming"
2727
class="files-list__row-name-link"
2828
data-cy-files-list-row-name-link
29-
v-bind="linkTo.params"
30-
@click="$emit('click', $event)">
29+
v-bind="linkTo.params">
3130
<!-- File name -->
3231
<span class="files-list__row-name-text">
3332
<!-- Keep the displayName stuck to the extension to avoid whitespace rendering issues-->

apps/files/src/components/FileEntryGrid.vue

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
:dragover="dragover"
3333
:grid-mode="true"
3434
:source="source"
35+
@auxclick.native="execDefaultAction"
3536
@click.native="execDefaultAction" />
3637

3738
<FileEntryName ref="name"
@@ -41,7 +42,8 @@
4142
:grid-mode="true"
4243
:nodes="nodes"
4344
:source="source"
44-
@click="execDefaultAction" />
45+
@auxclick.native="execDefaultAction"
46+
@click.native="execDefaultAction" />
4547
</td>
4648

4749
<!-- Actions -->

apps/files/src/components/FileEntryMixin.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,8 @@ export default defineComponent({
210210
},
211211

212212
execDefaultAction(event) {
213-
if (event.ctrlKey || event.metaKey) {
213+
// if ctrl+click or middle mouse button, open in new tab
214+
if (event.ctrlKey || event.metaKey || event.button === 1) {
214215
event.preventDefault()
215216
window.open(generateUrl('/f/{fileId}', { fileId: this.fileid }))
216217
return false

0 commit comments

Comments
 (0)