Release directory iterator and thereby its potential directory lock prior to deleting a directory, to avoid e.g. "Text file busy" error with VirtualBox shared folder storage

dennisverspuij · dennisverspuij · commit a275497dc096 · 2024-06-21T23:54:44.000+02:00
Signed-off-by: Dennis Verspuij &lt;6680484+dennisverspuij@users.noreply.github.com&gt;
diff --git a/lib/private/Files/Storage/Local.php b/lib/private/Files/Storage/Local.php
@@ -117,6 +117,7 @@ public function rmdir($path) {
 				}
 				$it->next();
 			}
+			unset($it);  // Release iterator and thereby its potential directory lock (e.g. in case of VirtualBox shared folders)
 			clearstatcache(true, $this->getSourcePath($path));
 			return rmdir($this->getSourcePath($path));
 		} catch (\UnexpectedValueException $e) {

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ public function rmdir($path) {`
`117`	`117`	`}`
`118`	`118`	`$it->next();`
`119`	`119`	`}`
	`120`	`+ unset($it); // Release iterator and thereby its potential directory lock (e.g. in case of VirtualBox shared folders)`
`120`	`121`	`clearstatcache(true, $this->getSourcePath($path));`
`121`	`122`	`return rmdir($this->getSourcePath($path));`
`122`	`123`	`} catch (\UnexpectedValueException $e) {`