Use local variable for directory name

kesselb · kesselb · commit 89a2845868e0 · 2019-08-26T13:57:00.000+02:00
Signed-off-by: Daniel Kesselberg &lt;mail@danielkesselberg.de&gt;
diff --git a/apps/files_external/lib/Lib/Storage/AmazonS3.php b/apps/files_external/lib/Lib/Storage/AmazonS3.php
@@ -334,8 +334,9 @@ public function opendir($path) {
 				// sub folders
 				if (is_array($result['CommonPrefixes'])) {
 					foreach ($result['CommonPrefixes'] as $prefix) {
-						$files[] = substr(trim($prefix['Prefix'], '/'), strlen($path));
-						$this->directoryCache[trim($prefix['Prefix'], '/')] = true;
+						$directoryName = trim($prefix['Prefix'], '/');
+						$files[] = substr($directoryName, strlen($path));
+						$this->directoryCache[$directoryName] = true;
 					}
 				}
 				if (is_array($result['Contents'])) {

Original file line number	Diff line number	Diff line change
`@@ -334,8 +334,9 @@ public function opendir($path) {`
`334`	`334`	`// sub folders`
`335`	`335`	`if (is_array($result['CommonPrefixes'])) {`
`336`	`336`	`foreach ($result['CommonPrefixes'] as $prefix) {`
`337`		`- $files[] = substr(trim($prefix['Prefix'], '/'), strlen($path));`
`338`		`- $this->directoryCache[trim($prefix['Prefix'], '/')] = true;`
	`337`	`+ $directoryName = trim($prefix['Prefix'], '/');`
	`338`	`+ $files[] = substr($directoryName, strlen($path));`
	`339`	`+ $this->directoryCache[$directoryName] = true;`
`339`	`340`	`}`
`340`	`341`	`}`
`341`	`342`	`if (is_array($result['Contents'])) {`