Add comments

Signed-off-by: Louis Chemineau <louis@chmn.me>

Author: artonge

apps/files_external/lib/Lib/Storage/AmazonS3.php

@@ -386,6 +386,7 @@ public function stat($path) {
 			if ($this->is_dir($path)) {
 				//folders don't really exist
 				$stat['size'] = -1; //unknown
+				// 1. The fact that mtime is always 'now' leads to...
 				$stat['mtime'] = time();
 				$cacheEntry = $this->getCache()->get($path);
 				if ($cacheEntry instanceof CacheEntry && $this->getMountOption('filesystem_check_changes', 1) !== 1) {

lib/private/Files/Cache/Scanner.php

@@ -396,6 +396,8 @@ protected function scanChildren($path, $recursive = self::SCAN_RECURSIVE, $reuse
 			}
 		}
 		if ($this->cacheActive) {
+			// 4. The cached to be updated every time the folder is acceceed.
+			// But this is always called with -1, because ...
 			$this->cache->update($folderId, ['size' => $size]);
 		}
 		$this->emit('\OC\Files\Cache\Scanner', 'postScanFolder', [$path, $this->storageId]);

lib/private/Files/Storage/Common.php

@@ -328,6 +328,7 @@ protected function searchInDir($query, $dir = '') {
 	 * @return bool
 	 */
 	public function hasUpdated($path, $time) {
+		// 2. This being always true, and ...
 		return $this->filemtime($path) > $time;
 	}
 

lib/private/Files/View.php

@@ -1348,6 +1348,7 @@ private function getCacheEntry($storage, $internalPath, $relativePath) {
 				$scanner = $storage->getScanner($internalPath);
 				$scanner->scan($internalPath, Cache\Scanner::SCAN_SHALLOW);
 				$data = $cache->get($internalPath);
+				// 3. needsUpdate to also be always true, and ...
 			} elseif (!Cache\Scanner::isPartialFile($internalPath) && $watcher->needsUpdate($internalPath, $data)) {
 				$this->lockFile($relativePath, ILockingProvider::LOCK_SHARED);
 				$watcher->update($internalPath, $data);