Allow to disable a popover menu button#387
Merged
Conversation
skjnldsv
requested changes
May 10, 2019
Contributor
skjnldsv
left a comment
There was a problem hiding this comment.
This popovermenu is deprecated in favor of an Action element now, any particular reason you came to edit this file? :)
Contributor
|
Contributor
Author
It is used in the update channel selector of the update notification app |
Contributor
|
I guess we should aim for the new Actions now then, no? |
Contributor
Author
|
skjnldsv
reviewed
May 13, 2019
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
d52f5dc to
14c0628
Compare
skjnldsv
approved these changes
May 13, 2019
Contributor
|
Let's get this in then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.